-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wen calculating 95th percentile, floor() maybe used instead of ceil() incorrectly #4963
Comments
There is a rounding function on the element number, you are suggesting we use a |
That's awesome, make my life much easier. Do you know how to create a pull request? If so, create one against the 1.2.x changing only this one file. If you need help, just chime in. |
TheWitness, there is one more question for you. 1.2.20(rrdtool 1.7.2) There is an error in the export time: But when I changed rrdtool to version 1.48, the problem disappeared, how can I go about it. |
Is your browsers time zone different than the servers? This is a regression when we introduced that feature. @thurban is working on a way to disable that until we get the feature more unified across not only Core Cacti, but the plugin architecture. This should be resolved before too long. Issue is here: |
My browser is in the same timezone as the server and it doesn't seem to be the same problem. |
Okay, but one issue per ticket. Can you do the pull request? |
Regarding the first question, I have already submitted. I don't know if it is correct, please take a look. |
So, you made a few mistakes. Easy to fix though. What you did was try to merge develop in to 1.2.x, which is the wrong way. What you need to do is switch to the 1.2.x branch before making your changes. If using the command line, you would do this: git checkout 1.2.x
vim lib/graph_variables.php If using the Desktop Client, then there is a dropdown as shown in the image below. Simply change to 1.2.x and make your changes. I find the Desktop Client pretty convenient. |
Sorry, please help to change it this time, I will learn. |
No problem, it's queued up, but I'm heading out for vacation for next week or so. Get it done when I get back. In the mean time maybe @xmacan can pull it together. I'll be monitoring from my phone. |
Will the calculation rules of 95nth_percentile involve php and rrdtool versions
Resolved. |
Make Tree the unlock process not have to rebuild the page
I have three sets of CACTI:
For example, the 5-minute data in September should be 12 * 24 * 30=8640 pieces of data, and 8640*0.05 is 432, which should be calculated from the 433rd piece of data.
But they are handled separately as follows:
I looked at the graph_variables.php code for 0.8.8a and 0.8.8h, they are all the same, don't know why this is the result.
The text was updated successfully, but these errors were encountered: