-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIB Parser can sometimes cause errors in later PHP versions #4971
Comments
Thanks @paulgevers! On vacation with the boss. So, it'll take a while. Thanks for taking the initiative! |
@browniebraun, can you tackle this one? |
I have to install 8.2 first ("still" on 8.1), but it is on my plate. 🫡 |
There's not much in the 8.2 depreciated list that would concern us I think. The main one is going to be ${var} usage and possibly strtolower()/strtoupper() no longer being locale aware (so we should use the mb_ versions of these functions). The other big one is the warnings that will be thrown if a class doesn't define the property that is being set prior to setting it. Where previously, you could just define the class: class myclass {
} Then do something daft like: $a = new myclass();
$a->undefined = 'defined'; This will now fail. Not sure if any of our code does that, but the libraries we use may also do that so will likely only show up during usage. |
NOTE: Other string functions such as stripos() etc are also affected by the lack of locale awareness change. NOTE 2: PHP 8.2 isn't even released yet, it's at RC 5 as at the time of writing this so anyone using that is really cutting their teeth at the moment. |
Yea got that thanks Mark. They also deprecated |
@netniV sorry if I confused you. I didn't want to claim that we have php 8.2 already, I just said that we are working on getting ready. The Debian |
No worries Paul, from a lint perspective we appear to have no issues in the core code, one or two in the plugins which I addressed already, but that doesn't stop runtime errors like the dynamic property blocking that they have now introduced. I have RC4 from the ppa-qa installed but I've yet to rub it with anger. |
Mmmhhh... self::method and parent::method seems to have been deprecated as well. |
@browniebraun, that's a bit of a problem too. |
I did a hack job to lib/database.php instead of extending PDO. It get's the job done and less work. |
Describe the bug
Debian is working on upgrading to php 8.2. Today, I received bug 1022229 in Debian about failing tests with that version of php.
To Reproduce
install php 8.2
Run the test suite
Notice the following (copied from here:
Expected behavior
The test should pass. More importantly there shouldn't be deprecation warnings in the logs when running cacti.
Desktop (please complete the following information)
OS: Debian unstable with php-defaults from experimental
wget version 1.21.3-1+b2
The text was updated successfully, but these errors were encountered: