Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.1 support with Installer #5033

Closed
browniebraun opened this issue Dec 4, 2022 · 6 comments
Closed

Improve PHP 8.1 support with Installer #5033

browniebraun opened this issue Dec 4, 2022 · 6 comments
Assignees
Labels
bug Undesired behaviour installer Installation issue PHP8 Issue related to PHP8 resolved A fixed issue
Milestone

Comments

@browniebraun
Copy link
Member

Describe the bug

Clean installation of 1.2.x branch, version 1.2.23, shows deprecated messages directly when the install wizard starts.

Action failed
Sorry, we could not process your last action.
Error:	200 OK
Reason:	
Deprecated: escapeshellcmd(): Passing null to parameter #1 ($command) of type string is deprecated in /var/www/html/cacti/lib/functions.php on line 4473

Deprecated: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated in /var/www/html/cacti/lib/installer.php on line 791
{"Mode":1,"Step":1,"Errors":[],"Eula":null,"Prev":{"Text":"Previous","Step":0,"Enabled":false,"Visible":true},"Next":{"Text":"Begin","Step":2,"Enabled":false,"Visible":true},"Test":{"Text":"Test Connection","Step":-4,"Enabled":true,"Visible":false},"Theme":"midwinter","StepData":{"Eula":null,"Theme":"midwinter","Language":"en-US"},"Html":"

Screenshots

Screenshot from 2022-12-04 18-05-19

Desktop (please complete the following information)

  • OS: [e.g. iOS]

Ubuntu 22.04.1 LTS

@browniebraun browniebraun added bug Undesired behaviour unverified Some days we don't have a clue installer Installation issue PHP8 Issue related to PHP8 and removed unverified Some days we don't have a clue labels Dec 4, 2022
@browniebraun
Copy link
Member Author

More output generated within final step of the installation wizard:

Deprecated: Implicit conversion from float-string "1670175096.0354" to int loses precision in /var/www/html/cacti/lib/installer.php on line 2654 {"Mode":null,"Step":"97","Errors":[],"Eula":"1","Prev":{"Text":"Previous","Step":96,"Enabled":true,"Visible":false},"Next":{"Text":"Next","Step":98,"Enabled":true,"Visible":false},"Test":{"Text":"Test Connection","Step":-4,"Enabled":true,"Visible":false},"Theme":"midwinter","StepData":{"Current":"41","Total":100},"Html":"

@TheWitness
Copy link
Member

Working.

TheWitness added a commit that referenced this issue Dec 4, 2022
Installer shows deprecated messages on PHP 8.1.2
TheWitness added a commit that referenced this issue Dec 4, 2022
@TheWitness
Copy link
Member

Should be good now.

@TheWitness TheWitness added the resolved A fixed issue label Dec 4, 2022
TheWitness added a commit that referenced this issue Dec 4, 2022
Installer shows deprecated messages on PHP 8.1.2
@TheWitness TheWitness added this to the v1.2.23 milestone Dec 4, 2022
@TheWitness TheWitness changed the title [1.2.x] - Installer shows deprecated messages on PHP 8.1.2 Installer shows deprecated messages on PHP 8.1.2 Dec 4, 2022
@TheWitness TheWitness self-assigned this Dec 4, 2022
@netniV
Copy link
Member

netniV commented Dec 5, 2022

Ouch, you should really move forward from 8.1.2. I thnk it's up to .13 now. :)

@netniV
Copy link
Member

netniV commented Dec 5, 2022

I believe that I fixed these warnings in 1.3. It wasn't backported but looks like @TheWitness has covered it. 8.1/8.2 isn't fully supported in 1.2.x.

@TheWitness
Copy link
Member

Found a few more in the installer based on check all pages this morning.

@netniV netniV changed the title Installer shows deprecated messages on PHP 8.1.2 Improve PHP 8.1 support with Installer Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour installer Installation issue PHP8 Issue related to PHP8 resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants