ss_host_disk.php php issue after upgrade PHP 8.1 (from 7.4)

[xmacan]

2022-12-18 21:31:16 - ERROR PHP ERROR: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in /usr/local/share/cacti/scripts/ss_host_disk.php:146 Stack trace: #0 /usr/local/share/cacti/scripts/ss_host_disk.php(146): abs('') #1 /usr/local/share/cacti/script_server.php(293):

With php 7.4 it was without issue

[TheWitness]

I guess I don't have enough 'big' volumes.

[TheWitness]

If you are monitoring Linux boxes, you might want to consider realStorageUnits=0 in your snmpd.conf

[TheWitness]

Can you pop a cacti_log() just before that call and figure out what the value is? I'm curious.

[xmacan]

Error message says: abs('') - value is empty.

2022-12-19 08:50:04 - CMDPHP
2022-12-19 08:50:04 - ERROR PHP ERROR: Uncaught TypeError: abs(): ....

Ok, it is problem with DS, but the same DS doesn't not cause error in PHP 7.4

[xmacan]

Easy fix:
if ($snmp_data < 0) {
change to
if ($snmp_data != '' && $snmp_data < 0) {

[xmacan]

I can prepare PR if you agree with this fix

[TheWitness]

I'm fine with it.