Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When filtering Device Templates, valid matches are not always shown #5188

Closed
browniebraun opened this issue Jan 24, 2023 · 5 comments
Closed

When filtering Device Templates, valid matches are not always shown #5188

browniebraun opened this issue Jan 24, 2023 · 5 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.24

Comments

@browniebraun
Copy link
Member

Describe the bug

Device Templates will no longer be filtered by a search pattern. Instead of returning matching records only, all table records will be displayed and matching records only highlighted. This is a misbehavior.
@browniebraun browniebraun added bug Undesired behaviour unverified Some days we don't have a clue labels Jan 24, 2023
@TheWitness
Copy link
Member

Please be more specific. It's working fine in my environment. What part of the search filter is not working? Do you have any plugins that are over-riding the default host page like potentially the monitor plugin?

@browniebraun
Copy link
Member Author

Maybe it has already been fixed in 1.2.x. Let me add a screenshot. I have the same behavior in dev and prod.

image

@browniebraun
Copy link
Member Author

Ok, the error is here in host_template.php and occurs whenever the class is set to 'unassigned' or 'all'. In this case $sql_where will be overwritten.

image

@browniebraun browniebraun removed the unverified Some days we don't have a clue label Jan 24, 2023
@TheWitness
Copy link
Member

Oh crap, Device Templates. Dah! Wake up @TheWitness

TheWitness added a commit that referenced this issue Jan 24, 2023
@TheWitness
Fixing #5188 - Device Template search
ffec028 
Device Template Filter broken
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team labels Jan 24, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 24, 2023
@TheWitness
Copy link
Member

Okay, resolved now.

@TheWitness TheWitness added the porting required Requires porting to develop label Jan 24, 2023
@netniV netniV changed the title 1.2.23 - Device Template Filter broken When filtering Device Templates, valid matches are not always shown Feb 15, 2023
@TheWitness TheWitness removed the porting required Requires porting to develop label Feb 20, 2023
@TheWitness TheWitness mentioned this issue Feb 20, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.24
Development

No branches or pull requests
2 participants
@TheWitness @browniebraun