Skip to content

Compatibility improvements for Classic Tab images under PHP 8.x #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheWitness opened this issue Jan 27, 2023 · 0 comments
Closed

Compatibility improvements for Classic Tab images under PHP 8.x #5200

TheWitness opened this issue Jan 27, 2023 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.24

Comments

@TheWitness
Copy link
Member

Describe the bug

The function get_classic_tabimage will throw errors in PHP8+

Expected behavior

Less Cacti errors.
@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Jan 27, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 27, 2023
TheWitness added a commit that referenced this issue Jan 27, 2023
@TheWitness
Fixing #5200 Tab Images Warnings
cdd6902 
Cacti function throws errors when attempting to render classic images in PHP8
@TheWitness TheWitness added resolved A fixed issue porting required Requires porting to develop labels Jan 27, 2023
@netniV netniV changed the title Cacti function throws errors when attempting to render classic images in PHP8 Compatibility improvements for Classic Tab display under PHP 8.x Feb 15, 2023
@netniV netniV changed the title Compatibility improvements for Classic Tab display under PHP 8.x Compatibility improvements for Classic Tab images under PHP 8.x Feb 15, 2023
@TheWitness TheWitness removed the porting required Requires porting to develop label Feb 20, 2023
@TheWitness TheWitness mentioned this issue Feb 20, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.24
Development

No branches or pull requests
1 participant
@TheWitness