Rebuilding the poller cache does not always work as expected

[xmacan]

I found that multiCPU_avg data source was updated during the update. Old code has a lot of parameters:
function ss_multicpu_avg($hostname,$snmp_community,$snmp_version, $snmp_port,$snmp_timeout)
new code has only host_id.

My poller cache looked like this:

So I haven't new data data ater update.

I tried system utilities -> rebuild poller cache. Unfortunately I'm not sure if I didn't run cli rebuild_poller_cache.php :-(
Result was:

Instead of host_id is here hostname. It seems that other parameters have been cut off.

Next run rebuild poller cache from web or cli = the same result.

management -> devices -> choose one -> repopulate poller cache = work well
Cli push_out_hosts.php = works well too.

For me it is very confusing. Why host repopulating cache is doing anything different than other repopulate action?

1.2.23 (and older version too, I think that I reported it before

[TheWitness]

Is this the latest 1.2.x branch or what?

[xmacan]

Last line of issue description - it is on 1.2.23 version. I've seen it on older versions. I can update to actual 1.2.24 branch and test it again if you want.

[TheWitness]

Please.

[xmacan]

The first problem. Old ss script has more parameters:
function ss_esxi_vhosts($hostname,$snmp_community,$snmp_port,$snmp_timeout) {
new has only one:
function ss_esxi_vhosts($device_id) {

So after update from (1.2.23 -> 1.2.24) data input method has few obsolete parameters:

[xmacan]

the rest. In poller cache I have:

After utilities->rebuild_poller_cache (gui) I got

That is wrong. Rebuild poller cache from cli - the same result.

Save device -> still wrong
php rebuild_poller_cache.php --host-id=611 --debug -> still wrong

php push_out_hosts.php --host-id=611 --debug -> OK
Device -> repopulate pller cache -> OK

[TheWitness]

Just looking at the rebuild script. Damn, it's wrong in a number of places. That script is not multiple-poller aware as of right now. Big oversight.