Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unsupported SQL Mode flags from being set #5434

Closed
TheWitness opened this issue Aug 4, 2023 · 0 comments
Closed

Prevent unsupported SQL Mode flags from being set #5434

TheWitness opened this issue Aug 4, 2023 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.25

Comments

@TheWitness
Copy link
Member

Describe the bug

This variable has not been used in more than a decade. Just removing it as it's breaking our build system.

Expected behavior

Cacti should not break itself when it's being tested.
@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Aug 4, 2023
@TheWitness TheWitness added this to the v1.2.25 milestone Aug 4, 2023
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Fixing #5434 - SQL Mode NO_AUTO_CREATE_USER
41426e8 
This setting is now braking out build test system.
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Fixing #5434 - SQL Mode NO_AUTO_CREATE_USER
82085f8 
This setting is now braking out build test system.
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
QA On #5434 - Next offender
9d2dcd6 
Will have to make one more commit after we see what is going on.
@TheWitness TheWitness changed the title Remove SQL Mode NO_AUTO_CREATE_USER as it's deprecated and removed from recent MySQL releases Remove SQL Mode NO_AUTO_CREATE_USER and NO_ENGINE_SUBTITUTION removed from MySQL 8.1+ releases Aug 4, 2023
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Finalizing #5434 - Remove these two settings entirely
5ce5c88
@TheWitness TheWitness added the resolved A fixed issue label Aug 4, 2023
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Last of the last on #5434 I hope
42ee72a
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
QA On #5434 - Next offender
9e01ad6 
Will have to make one more commit after we see what is going on.
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Finalizing #5434 - Remove these two settings entirely
68117e3
TheWitness added a commit that referenced this issue Aug 4, 2023
@TheWitness
Last of the last on #5434 I hope
a174a39
@netniV netniV changed the title Remove SQL Mode NO_AUTO_CREATE_USER and NO_ENGINE_SUBTITUTION removed from MySQL 8.1+ releases Prevent unsupported SQL Mode flags from being set Sep 3, 2023
TheWitness added a commit that referenced this issue Oct 14, 2023
@TheWitness
Fixing #5434 - Data Source Debug Lingers
f41dd41 
When deleting a single Data Source the table data_debug is not purged
TheWitness added a commit that referenced this issue Oct 14, 2023
@TheWitness
Fixing #5434 - Data Source Debug Lingers
fe9f8ca 
When deleting a single Data Source the table data_debug is not purged
TheWitness added a commit that referenced this issue Oct 14, 2023
@TheWitness
Revert "Fixing #5434 - Data Source Debug Lingers"
404f69d 
This reverts commit f41dd41.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.25
Development

No branches or pull requests
1 participant
@TheWitness