Skip to content

Improve compatibility for Advanced Ping under PHP 8.x #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anarkia1976 opened this issue Aug 31, 2023 · 5 comments
Closed

Improve compatibility for Advanced Ping under PHP 8.x #5475

anarkia1976 opened this issue Aug 31, 2023 · 5 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team
Milestone
v1.2.25

Comments

@anarkia1976
Copy link

Hi Guys,

i see this error into cacti log:

2023-08-31 02:35:08 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())
2023-08-31 02:35:08 - ERROR PHP ERROR: Uncaught TypeError: Unsupported operand types: float + string in /var/www/html/cacti/scripts/ss_fping.php:93 Stack trace: #0 /var/www/html/cacti/script_server.php(293): ss_fping() #1 {main} thrown in file: /var/www/html/cacti/scripts/ss_fping.php on line: 93

PHP: 8.1.2

thanks a lot. stefano.
@anarkia1976 anarkia1976 added bug Undesired behaviour unverified Some days we don't have a clue labels Aug 31, 2023
@TheWitness
Copy link
Member

@anarkia1976, please upload your version of the script.

@TheWitness
Copy link
Member

Never mind. Found it.

@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Aug 31, 2023
@TheWitness TheWitness modified the milestones: v1.2.24, v1.2.25 Aug 31, 2023
@TheWitness TheWitness changed the title [CACTI 1.2.25] PHP 8.x error - Unsupported operand types: float + string PHP 8.x error - Unsupported operand types: float + string Aug 31, 2023
@TheWitness
Copy link
Member

Test the pull request that I dropped in.

@anarkia1976
Copy link
Author

Test the pull request that I dropped in.

i have Merged it, i'm giving feedback tomorow. thanks a lot.

@anarkia1976
Copy link
Author

fixed.

netniV pushed a commit that referenced this issue Sep 3, 2023
@TheWitness
Fixing #5475 - Issue with ss_fping.php and PHP8 strict typing (#5477)
c59b6b9 
* QA: Broken Function

* QA: Two additional QA Items

- Do a check for IP address as dns_get_records() does not have a timeout and I don't use DNS
- Properly display information about MariaDB 11.

* Fixing #5475 - Ping Issues with Advanced Ping an PHP8

PHP 8.x error - Unsupported operand types: float + string

* QA: Fix two typos
@netniV netniV changed the title PHP 8.x error - Unsupported operand types: float + string Improve compatability for Advanced Ping under PHP 8.x Sep 3, 2023
@netniV netniV changed the title Improve compatability for Advanced Ping under PHP 8.x Improve compatibility for Advanced Ping under PHP 8.x Sep 3, 2023
TheWitness added a commit that referenced this issue Sep 6, 2023
@TheWitness
Fixing #5475 - Issue with ss_fping.php and PHP8 strict typing (#5477)
d395e6a 
* QA: Broken Function

* QA: Two additional QA Items

- Do a check for IP address as dns_get_records() does not have a timeout and I don't use DNS
- Properly display information about MariaDB 11.

* Fixing #5475 - Ping Issues with Advanced Ping an PHP8

PHP 8.x error - Unsupported operand types: float + string

* QA: Fix two typos
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team
Projects
None yet
Milestone
v1.2.25
Development

No branches or pull requests
2 participants
@TheWitness @anarkia1976