Improve PHP 8.1 support for incrementing only numbers

[infinitynet2011]

Fresh install cacti last version

2023-09-25 05:41:42 - CMDPHP PHP ERROR Backtrace: (/host.php[176]:host(), /host.php[1807]:html_header_sort_checkbox(), /lib/html.php[936]:CactiErrorHandler())
2023-09-25 05:41:42 - ERROR PHP DEPRECATED: Increment on non-alphanumeric string is deprecated in file: /var/www/html/cacti/lib/html.php on line: 936

This is happening every time I go to Console / Management / Device...

Thanks,
Gabe

[bmfmancini]

What version of PHP?

…

On Mon, Sep 25, 2023, 06:45 GV ***@***.***> wrote: Fresh install cacti last version 2023-09-25 05:41:42 - CMDPHP PHP ERROR Backtrace: (/host.php[176]:host(), /host.php[1807]:html_header_sort_checkbox(), /lib/html.php[936]:CactiErrorHandler()) 2023-09-25 05:41:42 - ERROR PHP DEPRECATED: Increment on non-alphanumeric string is deprecated in file: /var/www/html/cacti/lib/html.php on line: 936 This is happening every time I go to Console / Management / Device... Thanks, Gabe — Reply to this email directly, view it on GitHub <#5502>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADGEXTHZAPESTS4UT35IAZTX4FOE5ANCNFSM6AAAAAA5F4GX2M> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[infinitynet2011]

Cacti Version 1.2.25
PHP Version 8.3.0RC2
SQL 11.1.2-MariaDB

Last one, everything is up to date.

[TheWitness]

Running hot on all the latest tech @infinitynet2011 !

[TheWitness]

This looks like a PHP bug I think. The variable is static and is initialized to 0. Will keep digging.

[TheWitness]

Nope, just stupid old code.

[infinitynet2011]

The same type of error when I click on the Reporting tab (.. link/reports_admin.php)

2023-09-26 11:52:57 - CMDPHP PHP ERROR Backtrace: (/reports_admin.php[166]:reports(), /lib/html_reports.php[1954]:html_header_sort_checkbox(), /lib/html.php[936]:CactiErrorHandler())

2023-09-26 11:52:57 - ERROR PHP DEPRECATED: Increment on non-alphanumeric string is deprecated in file: /var/www/html/cacti/lib/html.php on line: 936

Thanks,

[TheWitness]

Yea, same API.

[TheWitness]

This should be resolved now. If you can confirm and then close if everything is working.