Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Data Input Methods #614

Closed
eschoeller opened this issue Apr 25, 2017 · 8 comments
Closed

Duplicate Data Input Methods #614

eschoeller opened this issue Apr 25, 2017 · 8 comments
Labels
enhancement General tag for an enhancement

Comments

@eschoeller
Copy link

I believe it would be extremely useful to have an option to duplicate data input methods, similar to how you can duplicate so many other things in Cacti ... many thanks!

@cigamit cigamit added the enhancement General tag for an enhancement label Apr 25, 2017
@g1augusto
Copy link

Please also Data queries!!! :)

@cigamit
Copy link
Member

cigamit commented Apr 28, 2017

x82,. tell me why? Its important.

@eschoeller
Copy link
Author

I just looked through most of the data queries I have created in the past. I do see some instances where I would have benefited from having the ability to duplicate an existing data query. There are a few of these out there where I ended up needing to make 2-6 different data queries which were extremely similar to one another - save for perhaps using a different XML file. It may seem to defeat the purpose of using a data query in the first place, but it was necessary given the situations.
If it's relatively easy to implement the functionality to duplicate a data query what harm would it do?
image
image

@g1augusto
Copy link

x82,. tell me why? Its important.

In my case I am building up device templates that refers at different data profiles (30 sec - 1 min - 5 min).
This is to simplify the operations within my team or people that are less inclined to understand cacti's architecture. For them I would just have a "Cisco Router 30 secs" or "Cisco Router 1 min" template, this is why replicating Data queries may save me some time.

PS : I know that it's possible to select a specific data profile for each data source, making things even easier for me, but as I said, I need to build and let other people maintain it as they go.

But any customization for a specific purpose of a certain preset data query or template would benefit of a duplication function.

Thanks for looking into this

@cigamit
Copy link
Member

cigamit commented Apr 29, 2017

Okay, but when duplicating a Data Query, what do you expect to be duplicated? Does it cascade, to the Graph Templates and Data Template, or is it just the Data Query, the Graph Template associations, and Suggested Values?

@eschoeller
Copy link
Author

I would say just the data query including the graph template associations and suggested values. It doesn't do anything to mess with actual graph templates and data templates downstream. I believe this is what I would expect to happen if I chose to duplicate a data query.

@ronytomen ronytomen modified the milestone: Cacti Release 1.2.0 May 5, 2017
@cigamit cigamit changed the title Feature Request: Duplicate Data Input Methods Duplicate Data Input Methods Feb 6, 2018
@cigamit cigamit added the gui UI related issue label Feb 6, 2018
@cigamit cigamit removed the gui UI related issue label Mar 4, 2018
@cigamit
Copy link
Member

cigamit commented Aug 20, 2018

I just discovered that if you make the Data Source Profile as per Data Source in the Data Source Template, that you will be prompted at create time for the Data Source Profile to use. So, the only thing that is really required here is the ability to duplicate a Data Input method. Otherwise, just enable the ability to specify the Data Source Profile at the Data Template level. It works for normal Graph Templates and Data Queries.

cigamit added a commit that referenced this issue Aug 20, 2018
Duplicate Data Input Methods
@cigamit
Copy link
Member

cigamit commented Aug 20, 2018

This is resolved now. Thanks for everyone's patience.

@cigamit cigamit closed this as completed Aug 20, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

4 participants