When translating, quotes may cause incorrect text to appear

[yonggang-xiao]

Describe the bug

Using 1.2.x branch
Same problem like this issue #5750
<p style="display:table-cell;overflow:auto">您在此表单上有未保存的更改.如果按'继续',这些更改将被丢弃.按'取消'继续编辑表单.</p>

Expected behavior

English language is correct
<p style="display:table-cell;overflow:auto">You have unsaved changes on this form. If you press &#39;Continue&#39; these changes will be discarded. Press &#39;Cancel&#39; to continue editing the form.</p>

Screenshots

[TheWitness]

Can you go to https://translate.cacti.net. Create an account and fix it there first? Let us know when it's fixed.

[TheWitness]

You can do it locally to. Goto the locales/po folder, open the Chinese pot file make the changes and run ./build_gettext.sh

[yonggang-xiao]

You can do it locally to. Goto the locales/po folder, open the Chinese pot file make the changes and run ./build_gettext.sh

I found the text in pot file is correct

#: lib/html_form.php:1403
msgid "You have unsaved changes on this form.  If you press 'Continue' these changes will be discarded.  Press 'Cancel' to continue editing the form."
msgstr "您在此表单上有未保存的更改.如果按'继续',这些更改将被丢弃.按'取消'继续编辑表单."

If the lib/html_form.php file should use __esc() function instead of __() ?

function warningMessage(href, type, scroll_or_id) {
                        title='<?php print __esc('Warning Unsaved Form Data');?>
';
                        returnStr = '<div id="messageContainer" style="display:n
one">' +
                                '<h4><?php print __('Unsaved Changes Detected');
?></h4>' +
                                '<p style="display:table-cell;overflow:auto"><?php print __('You have unsaved changes on this form.  If you press &#39;Continue&#39; these changes will be discarded.  Press &#39;Cancel&#39; to continue editing the form.');?></p>' +
                                '</div>';

[TheWitness]

Likely we have more of these issues. Let me fix for the develop branch.

[TheWitness]

Can you test first?

[yonggang-xiao]

Yes, the js error has been fixed using __esc() and the page function is OK.
But I am not sure the text in pot file is ', why the __() function return the decoded text ' ?

[TheWitness]

Feel free to make changes. If you make a pull request, please do it in develop.