Skip to content

Modify automation to test for data before creating graphs #645

Closed

Description

@cigamit

Some templates and automation routines are quite ignorant of the fact that some OID's do not exist, but create the graphs anyway. We should always test the data source before creating it.

Activity

  1. eschoeller commented on Mar 21, 2021

    @eschoeller

    Hey @TheWitness maybe #4182 fixed this?

  2. TheWitness commented on Mar 21, 2021

    @TheWitness
    Member

    No, but give me few days, on a streak.

  3. eschoeller commented on Mar 22, 2021

    @eschoeller

    Lol yeah you are!

    No rush on this one from my end. Just happened to notice it and it sounded similar enough to the other issue.

  4. added a commit that references this issue on Mar 24, 2021
  5. added this to the v1.2.17 milestone on Mar 24, 2021
  6. TheWitness commented on Mar 24, 2021

    @TheWitness
    Member

    @eschoeller, can you please test these. I need Data Queries tested. I've tested script and snmp, and they both appear working just fine. Note, remote agent is not functional yet. So, no remote data collectors unless the main Cacti can reach the devices.

  7. anarkia1976 commented on Mar 25, 2021

    @anarkia1976

    Hi, i have these errors:

    2021-03-25 12:04:22 - CMDPHP PHP ERROR NOTICE Backtrace: (/host.php[70]:form_actions(), /host.php[327]:automation_update_device(), /lib/api_automation.php[3953]:automation_execute_data_query(), /lib/api_automation.php[2206]:create_dq_graphs(), /lib/api_automation.php[2618]:test_data_sources(), /lib/functions.php[1594]:test_data_source(), /lib/functions.php[1784]:CactiErrorHandler())
    2021-03-25 12:04:22 - ERROR PHP NOTICE: Undefined variable: outputs in file: /var/www/html/cacti/lib/functions.php on line: 1784

    the problem arises when automation has to create graphs related to firewall interfaces. (atuomation --> graphs rules).

    thanks a lot.

  8. TheWitness commented on Mar 25, 2021

    @TheWitness
    Member

    @anarkia1976, thanks for testing. Update soon.

  9. added a commit that references this issue on Mar 25, 2021
  10. TheWitness commented on Mar 25, 2021

    @TheWitness
    Member

    Try again.

  11. anarkia1976 commented on Mar 25, 2021

    @anarkia1976

    Error attached:
    image
    thanks.

  12. eschoeller commented on Mar 25, 2021

    @eschoeller

    Sorry I'm not in the greatest position to test right now ... only have a prod environment that is ... running on questionable/overloaded hardware (I guess?). New hardware upgrade coming ...

  13. TheWitness commented on Mar 25, 2021

    @TheWitness
    Member

    One step closer. Next commit should fix it the rest of the way.

  14. added a commit that references this issue on Mar 25, 2021
  15. added a commit that references this issue on Apr 2, 2021
  16. locked and limited conversation to collaborators on Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    apiAPI related issuesautomationAutomation related issueenhancementGeneral tag for an enhancementresolvedA fixed issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions