Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify automation to test for data before creating graphs #645

Closed
cigamit opened this issue May 1, 2017 · 10 comments
Closed

Modify automation to test for data before creating graphs #645

cigamit opened this issue May 1, 2017 · 10 comments
Labels
api API related issues automation Automation related issue enhancement General tag for an enhancement resolved A fixed issue
Milestone

Comments

@cigamit
Copy link
Member

cigamit commented May 1, 2017

Some templates and automation routines are quite ignorant of the fact that some OID's do not exist, but create the graphs anyway. We should always test the data source before creating it.

@cigamit cigamit added the enhancement General tag for an enhancement label May 13, 2017
@cigamit cigamit added automation Automation related issue api API related issues labels Feb 6, 2018
@eschoeller
Copy link

Hey @TheWitness maybe #4182 fixed this?

@TheWitness
Copy link
Member

No, but give me few days, on a streak.

@eschoeller
Copy link

eschoeller commented Mar 22, 2021

Lol yeah you are!

No rush on this one from my end. Just happened to notice it and it sounded similar enough to the other issue.

TheWitness added a commit that referenced this issue Mar 24, 2021
So, this is not 100% finished yet as it does not currently work with the Remote Agent.  However needed some testers.
This change also deprecates Script Server calls being called without the proc_open() command which was a requirement from the early 2000's for a PHP version I don't even remember.
The change also improves logging when creating graphs via automation.
Lastly, marking #3572 as resolved as it was resolved in another fix over the weekend.
@TheWitness TheWitness added the resolved A fixed issue label Mar 24, 2021
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 24, 2021
@TheWitness
Copy link
Member

@eschoeller, can you please test these. I need Data Queries tested. I've tested script and snmp, and they both appear working just fine. Note, remote agent is not functional yet. So, no remote data collectors unless the main Cacti can reach the devices.

@anarkia1976
Copy link

anarkia1976 commented Mar 25, 2021

Hi, i have these errors:

2021-03-25 12:04:22 - CMDPHP PHP ERROR NOTICE Backtrace: (/host.php[70]:form_actions(), /host.php[327]:automation_update_device(), /lib/api_automation.php[3953]:automation_execute_data_query(), /lib/api_automation.php[2206]:create_dq_graphs(), /lib/api_automation.php[2618]:test_data_sources(), /lib/functions.php[1594]:test_data_source(), /lib/functions.php[1784]:CactiErrorHandler())
2021-03-25 12:04:22 - ERROR PHP NOTICE: Undefined variable: outputs in file: /var/www/html/cacti/lib/functions.php on line: 1784

the problem arises when automation has to create graphs related to firewall interfaces. (atuomation --> graphs rules).

thanks a lot.

@TheWitness
Copy link
Member

@anarkia1976, thanks for testing. Update soon.

TheWitness added a commit that referenced this issue Mar 25, 2021
@TheWitness
Copy link
Member

Try again.

@anarkia1976
Copy link

Error attached:
image
thanks.

@eschoeller
Copy link

Sorry I'm not in the greatest position to test right now ... only have a prod environment that is ... running on questionable/overloaded hardware (I guess?). New hardware upgrade coming ...

@TheWitness
Copy link
Member

One step closer. Next commit should fix it the rest of the way.

TheWitness added a commit that referenced this issue Mar 25, 2021
TheWitness added a commit that referenced this issue Apr 2, 2021
This change allows for testing of data source from the Graphs New page to reduce the likelihood of graphs being created that will never be rendered
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api API related issues automation Automation related issue enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants