Skip to content

Update min version to build from source #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Conversation

deefour
Copy link

@deefour deefour commented Feb 15, 2018

1. What does this change do, exactly?

Updates the minimum version of Go required to build from source. 1.8 fails since #2009 from the introduction of sync.Map

2. Please link to the relevant issues.

#2009

3. Which documentation changes (if any) need to be made because of this PR?

This is the doc change.

4. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I am willing to help maintain this change if there are issues with it later

Re: caddyserver#2009, 1.9 or newer is needed because of the introduction of `sync.Map`
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mholt mholt merged commit 6f4cf7e into caddyserver:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants