Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for freebsd/arm64 #2956

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Add support for freebsd/arm64 #2956

merged 1 commit into from
Jan 12, 2020

Conversation

dmgk
Copy link

@dmgk dmgk commented Jan 3, 2020

Currently, caddy doesn't build on freebsd/arm64 due to outdated golang.org/x/sys and golang.org/x/net dependencies:

# golang.org/x/sys/unix
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20190904154756-749cb33beabd/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128
# golang.org/x/net/ipv4
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_asmreq.go:47:31: undefined: ipMreq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:20:18: undefined: sysIP_RECVTTL
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:21:18: undefined: sysIP_RECVDSTADDR
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:22:18: undefined: sysIP_RECVIF
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:26:79: undefined: sysIP_TOS
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:27:79: undefined: sysIP_TTL
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:28:79: undefined: sysIP_MULTICAST_TTL
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:29:79: undefined: sysIP_MULTICAST_IF
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:60:11: undefined: groupReq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:67:12: undefined: groupSourceReq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv4/sys_freebsd.go:29:79: too many errors
# golang.org/x/net/ipv6
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/icmp.go:37:2: undefined: icmpv6Filter
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/icmp_bsd.go:9:10: undefined: icmpv6Filter
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/icmp_bsd.go:13:10: undefined: icmpv6Filter
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/icmp_bsd.go:17:10: undefined: icmpv6Filter
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/icmp_bsd.go:27:10: undefined: icmpv6Filter
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:61:11: undefined: sockaddrInet6
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:68:11: undefined: inet6Pktinfo
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:72:13: undefined: ipv6Mreq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:76:11: undefined: groupReq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:83:12: undefined: groupSourceReq
../../go/pkg/mod/golang.org/x/net@v0.0.0-20190930134127-c5a3c61f89f3/ipv6/sys_freebsd.go:83:12: too many errors

This PR updates golang.org/x/sys and golang.org/x/net to versions that support freebsd/arm64.

@claassistantio
Copy link

claassistantio commented Jan 3, 2020 •
edited
Loading

CLA assistant check)
All committers have signed the CLA.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 6, 2020
www/caddy: Update to 1.0.4
3d1351a 
- While here, unbreak on aarch64 (caddyserver/caddy#2956)

PR:		242441
Submitted by:	Shawn Wilsher <me@shawnwilsher.com>
Reviewed by:	GremL1N <viktor.dvz@gmail.com>, dmgk
Approved by:	maintainer timeout (fabian.freyer@physik.tu-berlin.de, 1 month)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@522216 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 6, 2020
@dmgk
www/caddy: Update to 1.0.4
5f79b8e 
- While here, unbreak on aarch64 (caddyserver/caddy#2956)

PR:		242441
Submitted by:	Shawn Wilsher <me@shawnwilsher.com>
Reviewed by:	GremL1N <viktor.dvz@gmail.com>, dmgk
Approved by:	maintainer timeout (fabian.freyer@physik.tu-berlin.de, 1 month)
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Jan 6, 2020
@dmgk
www/caddy: Update to 1.0.4
23f6bfa 
- While here, unbreak on aarch64 (caddyserver/caddy#2956)

PR:		242441
Submitted by:	Shawn Wilsher <me@shawnwilsher.com>
Reviewed by:	GremL1N <viktor.dvz@gmail.com>, dmgk
Approved by:	maintainer timeout (fabian.freyer@physik.tu-berlin.de, 1 month)


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@522216 35697150-7ecd-e111-bb59-0022644237b5
mholt
mholt approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this slipped through my inbox -- thanks for the PR!

@mholt mholt merged commit a976629 into caddyserver:master Jan 12, 2020
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this pull request Jan 10, 2024
@dmgk
www/caddy: Update to 1.0.4
6049e05 
- While here, unbreak on aarch64 (caddyserver/caddy#2956)

PR:		242441
Submitted by:	Shawn Wilsher <me@shawnwilsher.com>
Reviewed by:	GremL1N <viktor.dvz@gmail.com>, dmgk
Approved by:	maintainer timeout (fabian.freyer@physik.tu-berlin.de, 1 month)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmgk @claassistantio @mholt