Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: Add Caddyfile scheme shorthand for h2c #3629

Merged
merged 2 commits into from Nov 23, 2020
Merged

reverseproxy: Add Caddyfile scheme shorthand for h2c #3629

merged 2 commits into from Nov 23, 2020

Conversation

francislavoie
Copy link
Member

Closes #3628

@francislavoie francislavoie added this to the 2.x milestone Aug 4, 2020
@francislavoie francislavoie mentioned this pull request Aug 4, 2020
Closed
@mholt mholt added the under review 🧐 Review is pending before merging label Aug 4, 2020
@francislavoie francislavoie modified the milestones: 2.x, v2.3.0 Nov 1, 2020
mholt
mholt requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about readability.

modules/caddyhttp/reverseproxy/caddyfile.go Outdated Show resolved Hide resolved
mholt
mholt approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this

@mholt mholt merged commit 4a641f6 into caddyserver:master Nov 23, 2020
@francislavoie francislavoie deleted the h2c-shorthand branch November 23, 2020 19:23
@francislavoie francislavoie mentioned this pull request Nov 24, 2020
Merged
@francislavoie francislavoie mentioned this pull request Sep 19, 2021
Merged
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

Support h2c URI scheme for reverse proxy upstream address
2 participants
@francislavoie @mholt