Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Remove common_log field and single_field encoder (#4149) #4282

Merged
merged 5 commits into from
Nov 29, 2021

Conversation

mholt
Copy link
Member

@mholt mholt commented Aug 16, 2021

Follows up on #4149 by removing common log format and the single_field encoder, which was a hack to preserve CLF logs. However these features have compliance problems and were only introduced in Caddy 2 to help people transition to structured logs, so it's time to remove them.

Will merge this sometime after the v2.4.4 release.

@mholt mholt added the under review 🧐 Review is pending before merging label Aug 16, 2021
@mholt mholt added this to the v2.5.0 milestone Aug 16, 2021
@francislavoie
Copy link
Member

francislavoie commented Aug 16, 2021

Hmm. Could we at least mark the SingleFieldEncoder as deprecated for at least 1 minor version (log a warning on provision)?

Feels weird to remove so suddenly. I'd rather at least give people a chance to move away from it. Not everyone reads release notes, but hopefully the warnings will be noticed.

I propose we merge this to the 2.5 branch, and deprecate single_field in there, then remove this altogether in 2.6.

@mholt
Copy link
Member Author

mholt commented Aug 17, 2021

It has been announced for a while, but I'm OK with emitting a warning for a minor version, I suppose. 😢

@francislavoie
Copy link
Member

francislavoie commented Aug 17, 2021

Yeah. I would love to YOLO on this, but I feel like we need to go slow to maintain respect in the project from the community 😅

@mholt
Copy link
Member Author

mholt commented Aug 17, 2021

Could we at least mark the SingleFieldEncoder as deprecated for at least 1 minor version (log a warning on provision)?

Done in 8a974a4

@francislavoie
Copy link
Member

I'll merge this now, since we know our next release will be 2.5.0.

@francislavoie francislavoie removed the do not merge ⛔ Not ready yet! label Nov 29, 2021
@francislavoie francislavoie merged commit 0eb0b60 into master Nov 29, 2021
@francislavoie francislavoie deleted the common-log-removal branch November 29, 2021 06:08
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants