Typo fix + status syntax fix + WebDAV Update #107

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@Henrocker

Typo fix + status sysntax fix

Henrocker added some commits Jan 29, 2017
@Henrocker Henrocker Typo fix + status sysntax fix
Typo fix + status sysntax fix
46780b6
@Henrocker Henrocker WebDAV fix
WebDAV now supported by current release of Caddy.
078fa2e
@Henrocker Henrocker changed the title from Typo fix + status sysntax fix to Typo fix + status syntax fix + WebDAV Update Jan 29, 2017
@mholt

Thank you! Just a couple little changes.

@@ -9,7 +9,7 @@ date: 2016-03-16 12:00:00+00:00
In this post, I'll walk you through how to set up ownCloud with Caddy for a secure, personal cloud service. I wrote this guide while configuring on Ubuntu 14.
-**Update: Caddy's current release doesn't support WebDav yet, resulting in the desktop/mobile clients not working. Support for this is already included in the development branch, so you can either wait a until the next release, or compile Caddy yourself.**
+**Update: Caddy now supports WebDAV.**
@mholt
mholt Jan 29, 2017 Member

We can take this line out entirely. ;)

@Henrocker
Henrocker Jan 29, 2017 edited

You are right, but I thought about the people revisiting the page after a while and seeing that the WebDav annotation is gone, that they might be thinking the feature is still not available for them, while the opposite is true. People might see the updated annotation and can then be sure WebDav works. Though I think in the near future we can delete the disclaimer.

@@ -135,7 +135,7 @@ I made the following Caddyfile together with *mholt* and *dprandzioch*. The conf
# .htacces / data / config / ... shouldn't be accessible from outside
rewrite {
r ^/(?:\.htaccess|data|config|db_structure\.xml|README)
- status 403
+ to status 403
@mholt
mholt Jan 29, 2017 Member

I think this now requires a separate directive entirely, the status middleware: https://caddyserver.com/docs/status

@Henrocker
Henrocker Jan 29, 2017

I've got it like this in production on my server and it works. In Administrator panel, it says all checks passed, which means htaccess, etc. are not accessible, thus the parameter can be expressed like above :)

@mholt
mholt Jan 29, 2017 Member

Hmmm... I still think this is not correct. Check the docs for rewrite. /cc @DenBeke

@DenBeke
DenBeke Jan 29, 2017 Contributor

@Henrocker this used to work but the rewrite has changed as @mholt pointed out already.
What version of Caddy are you running?

@Henrocker
Henrocker Jan 29, 2017

I recompiled caddy from sources today. And the output from ./caddy -version is: Caddy (untracked dev build). As I stated, for me this works, becauseif I remove this line from my CaddyFile in my ownCloud section, the disclaimer appears again at the Administration panel.

@mholt
mholt Jan 29, 2017 Member

That's weird. Build it with build.bash to ensure the proper version information is recorded and let us know what it says.

@Henrocker
Henrocker Jan 30, 2017

I've rebuilt it with ./build.bash in the caddy directive but still, output is: Caddy (untracked dev build)

@mholt
mholt Jan 31, 2017 Member

Then you are not running the built version...

@Henrocker
Henrocker Jan 31, 2017

How can I then?

@Henrocker
Henrocker Feb 1, 2017

I've got Caddy to recompile with the parameter name after the /build.bash command.

Output: Caddy 0.9.5 (+dc6c986 Mi Feb 01 17:27:47 UTC 2017)

@mholt
mholt Feb 4, 2017 Member

There ya go! Does your Caddyfile work with that binary then? I would be surprised if it does.

@mholt mholt closed this Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment