Initial RPM package sources #2

carlwgeorge · 2019-10-21T15:04:15Z

These are the package sources used to build https://copr.fedorainfracloud.org/coprs/g/caddy/caddy/.

mholt · 2019-10-21T15:57:46Z

rpm/caddy.spec

+Version:        2.0.0~beta6
+%global tag     v2.0.0-beta6
+Release:        1%{?dist}
+Summary:        HTTP/2 web server with automatic HTTPS


FWIW, in the future I think I want to make summaries/descriptions of the project more generic, something like "Web server with automatic HTTPS" (since versions will get outdated)

Will still merge of course, just wanted to mention that

Sure, that's an easy adjustment.

mholt · 2019-10-21T15:58:24Z

rpm/caddy.spec

+
+
+%description
+Caddy is the HTTP/2 web server with automatic HTTPS.


(Here too, a more generic description will be forthcoming. We should chat about what a standard project description should be across all packages.)

mholt · 2019-10-21T15:59:10Z

rpm/main.go

+
+func main() {
+	caddycmd.Main()
+}


I also hope to simplify this main file so that the "standard" modules will be plugged in for you just by importing Caddy. That will help standardize each package I think. (Nothing you need to do here right now, just letting you know!)

And you can make whatever changes you need to to this file, and the next package build will use it.

mohammed90 · 2019-10-21T16:02:06Z

rpm/caddy.spec

+echo "require github.com/caddyserver/caddy/v2 %{tag}" >> go.mod
+go build \
+    -buildmode pie \
+    -compiler gc \


Any downside for including -trimpath for build that doesn't expose local path of the build server and be more reproducible?

I'm not familiar enough with go build flags to say for sure. I got these flags from Fedora's %gobuild macro. I didn't use the macro directly because it turns off go modules. Are you saying that without this flag, build server paths are encoded (maybe the wrong term here) into the final binary?

Yes. For example, on my laptop, Caddy lives in /Users/mohammed/github/caddy. If I build Caddy without it, then execute strings {caddy_executable}, you'll find lines listing the paths of Caddy source files prefixed with /Users/mohammed/github/caddy, e.g. /Users/mohammed/github/caddy/admin.go etc. With -trimpath, it'll just be github.com/caddyserver/caddy/admin.go, or something like this.

-trimpath
remove all file system paths from the resulting executable.
Instead of absolute file system paths, the recorded file names
will begin with either "go" (for the standard library),
or a module path@version (when using modules),
or a plain import path (when using GOPATH).

https://golang.org/cmd/go/#hdr-Compile_packages_and_dependencies

Yeah -- I think so anyway. Stack traces include (absolute) file paths without trimpath. Trimming the path can make stack traces a little more readable and the full file paths don't mean anything useful outside of dev environments.

According to a blogpost by Filippo, passing -s -w to -ldflags also still leaves meaningful information in the stack trace and not hinder understanding the underlying cause. But, I don't know if there are any negative consequences. Linkers are beyond my current knowledge level.

@Conan-Kudo Do you know if there is a reason Fedora's %gobuild doesn't include -trimpath? I found a few hits for that in the mailing list for build log output, but my recent copr builds don't have it.

I suspect that @jcajka didn't know about the flag? He's the one who maintains the build flags we set for %gobuild.

@carlwgeorge @Conan-Kudo the flag had landed in Apr this year in what to become 1.13, so there hasn't been really a chance for adding it with all the stuff happening in the f31. It does seem to me sensible to add it from end user perspective, compiler maintainer's..., not sure how it will be handled by the "new macros" infrastructure though. Could you please open a Fedora BZ against go-rpm-macros packageor feel free to open PR. Thanks for bringing this up.

https://bugzilla.redhat.com/show_bug.cgi?id=1763889

Initial RPM package sources

95dd3fa

mholt reviewed Oct 21, 2019

View reviewed changes

mholt approved these changes Oct 21, 2019

View reviewed changes

mholt merged commit ee5797c into master Oct 21, 2019

mohammed90 reviewed Oct 21, 2019

View reviewed changes

carlwgeorge deleted the rpm branch October 21, 2019 16:12

Initial RPM package sources #2

Initial RPM package sources #2

carlwgeorge commented Oct 21, 2019

mholt Oct 21, 2019

carlwgeorge Oct 21, 2019

mholt Oct 21, 2019

mholt Oct 21, 2019 •

edited

carlwgeorge Oct 21, 2019

mohammed90 Oct 21, 2019

carlwgeorge Oct 21, 2019 •

edited

mohammed90 Oct 21, 2019 •

edited

mholt Oct 21, 2019

mohammed90 Oct 21, 2019 •

edited

carlwgeorge Oct 21, 2019

Conan-Kudo Oct 21, 2019

jcajka Oct 21, 2019 •

edited

carlwgeorge Oct 21, 2019



		%description
		Caddy is the HTTP/2 web server with automatic HTTPS.

Initial RPM package sources #2

Initial RPM package sources #2

Conversation

carlwgeorge commented Oct 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mholt Oct 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlwgeorge Oct 21, 2019 • edited

Choose a reason for hiding this comment

mohammed90 Oct 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohammed90 Oct 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcajka Oct 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mholt Oct 21, 2019 •

edited

carlwgeorge Oct 21, 2019 •

edited

mohammed90 Oct 21, 2019 •

edited

mohammed90 Oct 21, 2019 •

edited

jcajka Oct 21, 2019 •

edited