Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PowerDNS support #15

Merged
merged 2 commits into from Dec 29, 2017

Conversation

@FrankPetrilli
Copy link
Contributor

FrankPetrilli commented Dec 27, 2017

Noticed the other pull request to add PowerDNS support was abandoned; I've created my own pull request with the changes you requested from the other.

Tested using PDNS_API_KEY, PDNS_API_URL env vars, and the following statement in a Caddyfile:

	tls {
		dns powerdns
	}
"net/url"

"github.com/mholt/caddy/caddytls"
"github.com/xenolf/lego/providers/dns/pdns"

This comment has been minimized.

Copy link
@mholt

mholt Dec 28, 2017

Member

While we're on the subject of spelling it out, do you think the package should be "powerdns" too? (I mean, in case there's some other DNS provider that starts with a P)

This comment has been minimized.

Copy link
@FrankPetrilli

FrankPetrilli Dec 28, 2017

Author Contributor

I used the name as given in lego. Further, it's common for PowerDNS to be referred to as pdns, as for example, the binary for the server is pdns_server.

@mholt

This comment has been minimized.

Copy link
Member

mholt commented Dec 29, 2017

Alright; fair enough. Thanks!

@mholt mholt merged commit 3fb56b8 into caddyserver:master Dec 29, 2017
@mholt mholt referenced this pull request Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.