New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prc #1

Merged
merged 7 commits into from Aug 23, 2015

Conversation

Projects
None yet
2 participants
@neilb
Contributor

neilb commented Aug 22, 2015

Hi Vladi,

This contains a good few changes, as discussed in email:

  • Min perl version set to 5.006, both in the code and in the dist metadata
  • Added prereqs to Makefile.PL
  • Changed test.t to have some basic tests for correct behaviour
  • Tweaked formatting of Changes to conform to CPAN::Changes::Spec
  • Changed use of indirect method notation (new Time::Progress) to direct notation (Time::Progress->new),
    as there are known problems with indirect notation.
  • Dropped Exporter, as it wasn't being used.
  • Added COPYRIGHT AND LICENSE section to doc, and set license metadata field to 'perl'.

Given the number of changes, it might be a good idea to do a developer release, since there are other CPAN modules using Time::Progress. I'm happy to do a developer release, if you'd like me to?

Given the number of changes already here, I thought I'd save the documentation work for another day :-)

Cheers,
Neil

cade-vs pushed a commit that referenced this pull request Aug 23, 2015

@cade-vs cade-vs merged commit 9f849fe into cade-vs:master Aug 23, 2015

@cade-vs

This comment has been minimized.

Show comment
Hide comment
@cade-vs

cade-vs Aug 23, 2015

Owner

hi Neil,

merged and already on cpan as 1.9 :)
you forgot to add your cpan ID in the Changes?

I don't see changes in the code so no need of dev release, I believe.
on other hand I'm not sure how to make a dev release :)

cheers,
Vladi.
ps: and thanks! :)

On Sat, 22 Aug 2015 14:58:49 -0700
Neil Bowers notifications@github.com wrote:

Hi Vladi,

This contains a good few changes, as discussed in email:

  • Min perl version set to 5.006, both in the code and in the dist metadata
  • Added prereqs to Makefile.PL
  • Changed test.t to have some basic tests for correct behaviour
  • Tweaked formatting of Changes to conform to CPAN::Changes::Spec
  • Changed use of indirect method notation (new Time::Progress) to direct notation,
    as there are known problems with indirect notation.
  • Dropped Exporter, as it wasn't being used.
  • Added COPYRIGHT AND LICENSE section to doc, and set license metadata field to 'perl'.

Given the number of changes, it might be a good idea to do a developer release, since there are other CPAN modules using Time::Progress. I'm happy to do a developer release, if you'd like me to?

Given the number of changes already here, I thought I'd save the documentation work for another day :-)

Cheers,
Neil
You can view, comment on, or merge this pull request online at:

#1

-- Commit Summary --

  • Tweaked formatting to confirm to CPAN::Changes::Spec
  • Changed two uses of indirect method notation in the doc
  • Added some tests that are checking for correct behaviour
  • Removed META.yml from repo, as it's generated by ExtUtils::MakeMaker
  • Moved demo.pl to examples/demo.pl
  • Dropped Exporter, as it wasn't being used
  • Specified prereqs in dist metadata along with the github repo

-- File Changes --

M Changes (43)
M MANIFEST (1)
D META.yml (10)
M Makefile.PL (62)
R examples/demo.pl (0)
M lib/Time/Progress.pm (35)
M t/test.t (65)

-- Patch Links --

https://github.com/cade-vs/perl-time-progress/pull/1.patch
https://github.com/cade-vs/perl-time-progress/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

Vladi Belperchinov-Shabanski
cade@bis.bg cade@biscom.net cade@datamax.bg http://cade.datamax.bg
pgp/gpg key 6F35B214 @ http://pgp.mit.edu

Owner

cade-vs commented Aug 23, 2015

hi Neil,

merged and already on cpan as 1.9 :)
you forgot to add your cpan ID in the Changes?

I don't see changes in the code so no need of dev release, I believe.
on other hand I'm not sure how to make a dev release :)

cheers,
Vladi.
ps: and thanks! :)

On Sat, 22 Aug 2015 14:58:49 -0700
Neil Bowers notifications@github.com wrote:

Hi Vladi,

This contains a good few changes, as discussed in email:

  • Min perl version set to 5.006, both in the code and in the dist metadata
  • Added prereqs to Makefile.PL
  • Changed test.t to have some basic tests for correct behaviour
  • Tweaked formatting of Changes to conform to CPAN::Changes::Spec
  • Changed use of indirect method notation (new Time::Progress) to direct notation,
    as there are known problems with indirect notation.
  • Dropped Exporter, as it wasn't being used.
  • Added COPYRIGHT AND LICENSE section to doc, and set license metadata field to 'perl'.

Given the number of changes, it might be a good idea to do a developer release, since there are other CPAN modules using Time::Progress. I'm happy to do a developer release, if you'd like me to?

Given the number of changes already here, I thought I'd save the documentation work for another day :-)

Cheers,
Neil
You can view, comment on, or merge this pull request online at:

#1

-- Commit Summary --

  • Tweaked formatting to confirm to CPAN::Changes::Spec
  • Changed two uses of indirect method notation in the doc
  • Added some tests that are checking for correct behaviour
  • Removed META.yml from repo, as it's generated by ExtUtils::MakeMaker
  • Moved demo.pl to examples/demo.pl
  • Dropped Exporter, as it wasn't being used
  • Specified prereqs in dist metadata along with the github repo

-- File Changes --

M Changes (43)
M MANIFEST (1)
D META.yml (10)
M Makefile.PL (62)
R examples/demo.pl (0)
M lib/Time/Progress.pm (35)
M t/test.t (65)

-- Patch Links --

https://github.com/cade-vs/perl-time-progress/pull/1.patch
https://github.com/cade-vs/perl-time-progress/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

Vladi Belperchinov-Shabanski
cade@bis.bg cade@biscom.net cade@datamax.bg http://cade.datamax.bg
pgp/gpg key 6F35B214 @ http://pgp.mit.edu

@neilb

This comment has been minimized.

Show comment
Hide comment
@neilb

neilb Aug 23, 2015

Contributor

Cool -- thanks for merging so quickly.

I'll do a separate PR with some documentation changes.

Contributor

neilb commented Aug 23, 2015

Cool -- thanks for merging so quickly.

I'll do a separate PR with some documentation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment