From 1f70385edad152adb8867f55927ffaad94c75ba7 Mon Sep 17 00:00:00 2001 From: "abhishek.jha" Date: Tue, 30 Jul 2024 15:18:35 -0700 Subject: [PATCH 1/3] Added logs to scanworkflow --- .../shadowing/ScanWorkflowActivityImpl.java | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java index 1df15c546..3cd696267 100644 --- a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java +++ b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java @@ -42,14 +42,22 @@ public ScanWorkflowActivityImpl(IWorkflowService serviceClient) { @Override public ScanWorkflowActivityResult scan(ScanWorkflowActivityParams params) throws Throwable { + log.info("Starting scan with params: {} ", params); + ListWorkflowExecutionsRequest scanRequest = new ListWorkflowExecutionsRequest() .setDomain(params.getDomain()) .setNextPageToken(params.getNextPageToken()) .setPageSize(params.getPageSize()) .setQuery(params.getWorkflowQuery()); + + log.debug("Created ListWorkflowExecutionsRequest: {} ", scanRequest); + log.info("Scanning workflows with query: {}", params.getWorkflowQuery()); + ListWorkflowExecutionsResponse resp = scanWorkflows(scanRequest); + log.info("Received response with {} executions", resp.getExecutions().size()); + List executions = samplingWorkflows(resp.getExecutions(), params.getSamplingRate()); @@ -60,15 +68,19 @@ public ScanWorkflowActivityResult scan(ScanWorkflowActivityParams params) throws .map(com.uber.cadence.internal.shadowing.WorkflowExecution::new) .collect(Collectors.toList())); result.setNextPageToken(resp.getNextPageToken()); + log.info("Scan completed with {} sampled executions", executions.size()); return result; } protected ListWorkflowExecutionsResponse scanWorkflows(ListWorkflowExecutionsRequest request) throws Throwable { + log.info("Scanning workflows for domain: {} with query: {}", request.getDomain(), request.getQuery()); try { - return RpcRetryer.retryWithResult( + ListWorkflowExecutionsResponse response = RpcRetryer.retryWithResult( RpcRetryer.DEFAULT_RPC_RETRY_OPTIONS, () -> this.serviceClient.ScanWorkflowExecutions(request)); + log.info("Successfully scanned workflows for domain: {}", request.getDomain()); + return response; } catch (BadRequestError | EntityNotExistsError | ClientVersionNotSupportedError e) { log.error( "failed to scan workflow records with non-retryable error. domain: " @@ -90,13 +102,16 @@ protected ListWorkflowExecutionsResponse scanWorkflows(ListWorkflowExecutionsReq protected List samplingWorkflows( List executionInfoList, double samplingRate) { + log.info("Sampling workflows with rate: {}", samplingRate); int capacity = (int) (executionInfoList.size() * samplingRate); capacity = Math.max(capacity, 1); - return executionInfoList + List sampledExecutions = executionInfoList .stream() .unordered() .map((executionInfo -> executionInfo.getExecution())) .limit((long) (capacity)) .collect(Collectors.toList()); + log.info("Sampled {} workflows out of {}", sampledExecutions.size(), executionInfoList.size()); + return sampledExecutions; } } From 46c84896c81db0b7a66b95577cd569d2352aead9 Mon Sep 17 00:00:00 2001 From: "abhishek.jha" Date: Tue, 30 Jul 2024 15:56:41 -0700 Subject: [PATCH 2/3] lint --- .../shadowing/ScanWorkflowActivityImpl.java | 25 +++++++++++-------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java index 3cd696267..7ebca70bb 100644 --- a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java +++ b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java @@ -74,11 +74,15 @@ public ScanWorkflowActivityResult scan(ScanWorkflowActivityParams params) throws protected ListWorkflowExecutionsResponse scanWorkflows(ListWorkflowExecutionsRequest request) throws Throwable { - log.info("Scanning workflows for domain: {} with query: {}", request.getDomain(), request.getQuery()); + log.info( + "Scanning workflows for domain: {} with query: {}", + request.getDomain(), + request.getQuery()); try { - ListWorkflowExecutionsResponse response = RpcRetryer.retryWithResult( - RpcRetryer.DEFAULT_RPC_RETRY_OPTIONS, - () -> this.serviceClient.ScanWorkflowExecutions(request)); + ListWorkflowExecutionsResponse response = + RpcRetryer.retryWithResult( + RpcRetryer.DEFAULT_RPC_RETRY_OPTIONS, + () -> this.serviceClient.ScanWorkflowExecutions(request)); log.info("Successfully scanned workflows for domain: {}", request.getDomain()); return response; } catch (BadRequestError | EntityNotExistsError | ClientVersionNotSupportedError e) { @@ -105,12 +109,13 @@ protected List samplingWorkflows( log.info("Sampling workflows with rate: {}", samplingRate); int capacity = (int) (executionInfoList.size() * samplingRate); capacity = Math.max(capacity, 1); - List sampledExecutions = executionInfoList - .stream() - .unordered() - .map((executionInfo -> executionInfo.getExecution())) - .limit((long) (capacity)) - .collect(Collectors.toList()); + List sampledExecutions = + executionInfoList + .stream() + .unordered() + .map((executionInfo -> executionInfo.getExecution())) + .limit((long) (capacity)) + .collect(Collectors.toList()); log.info("Sampled {} workflows out of {}", sampledExecutions.size(), executionInfoList.size()); return sampledExecutions; } From 2ec02a16c6c7dd8c30b937a5d8c49d46e181886d Mon Sep 17 00:00:00 2001 From: "abhishek.jha" Date: Tue, 30 Jul 2024 16:00:39 -0700 Subject: [PATCH 3/3] random change because pipeline was blocked. test --- .../cadence/internal/shadowing/ScanWorkflowActivityImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java index 7ebca70bb..9392f85a3 100644 --- a/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java +++ b/src/main/java/com/uber/cadence/internal/shadowing/ScanWorkflowActivityImpl.java @@ -87,7 +87,7 @@ protected ListWorkflowExecutionsResponse scanWorkflows(ListWorkflowExecutionsReq return response; } catch (BadRequestError | EntityNotExistsError | ClientVersionNotSupportedError e) { log.error( - "failed to scan workflow records with non-retryable error. domain: " + "failed to scan workflow records with non-retryable error. Domain: " + request.getDomain() + "; query: " + request.getQuery(),