feat: Remove WorkflowEngine Caching and add basic Activity/Workflow integration tests #55
+319
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
changed the title
shijiesheng
approved these changes
Nov 24, 2025
Comment on lines
+128
to
+132
| # We intentionally destroy pending tasks when shutting down the event loop. | ||
| # If our asyncio implementation supports it, disable the logs | ||
| if hasattr(task, "_log_destroy_pending"): | ||
| setattr(task, "_log_destroy_pending", False) | ||
| return task |
Member
There was a problem hiding this comment.
This actually indicates a real data leak issue. But we can fix it later
Member
There was a problem hiding this comment.
Discussed offline. There isn't a good solution to proactively delete the tasks. Cancelling tasks will trigger the workflow coroutine logic and may have unwanted side effects.
These tasks are weak references but will be deleted by GC eventually. So we'll just keep suppressing logging for now since it's expected behavior
timl3136
approved these changes
Nov 24, 2025
shijiesheng
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes