Test active-active behavior with concurrent SignalWithStart requests #7270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the query_workflow step to correctly retrieve signals, cleaning up some of the configuration
c-warren
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Shaddoll
reviewed
Sep 23, 2025
There was a problem hiding this comment.
It's not enabled in CI. Could you add it to https://github.com/cadence-workflow/cadence/blob/master/.github/workflows/replication-simulation.yml?
Shaddoll
reviewed
Sep 23, 2025
...tion/replication/testdata/replication_simulation_activeactive_same_wfid_signalwithstart.yaml
Show resolved
Hide resolved
Shaddoll
reviewed
Sep 24, 2025
| # This file is a replication simulation scenario spec. | ||
| # It is parsed into ReplicationSimulationConfig struct. | ||
| # Replication simulation for this file can be run via ./simulation/replication/run.sh activeactive_same_wfid_signalwithstart_delayed | ||
| # Dynamic config overrides can be set via config/dynamicconfig/replication_simulation_activeactive_same_wfid_signalwithstart_delayed.yml |
There was a problem hiding this comment.
this dynamic config file is not created
Shaddoll
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Tests conflict resolution when the same workflowID is used to create workflows in two different clusters with an Active-Active setup in the domain.
Why?
Cadence does not support two workflows existing with the same workflow ID. When a domain is configured active-active it can be possible for a user to make two simultaneous requests to two different clusters with the same workflow ID. When this happens, both workflows will run temporarily until the clusters have replicated their data to the other, at which point the conflict will have to be resolved.
This test is a follow up to #7265, testing the scenario when SignalWithStart is used (rather than StartWorkflow).
How did you test it?
Locally + against dev canary domains.
Potential risks
N/A
Release notes
N/A
Documentation Changes
N/A