Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DefaultPrivate property to SearchEngines policy #111

Closed
cadeyrn opened this issue Oct 16, 2019 · 2 comments
Closed

add DefaultPrivate property to SearchEngines policy #111

cadeyrn opened this issue Oct 16, 2019 · 2 comments

Comments

@cadeyrn
Copy link
Owner

@cadeyrn cadeyrn commented Oct 16, 2019

add DefaultPrivate property to SearchEngines policy => Firefox 71+
https://bugzilla.mozilla.org/show_bug.cgi?id=1587804

@cadeyrn cadeyrn added this to the Version 6.0.0 milestone Oct 16, 2019
@varshannagarajan

This comment has been minimized.

Copy link
Contributor

@varshannagarajan varshannagarajan commented Oct 17, 2019

Hi, If you would like me to work on this I can. I just have a couple questions though, I understand that the mainstream property would be 71.0, but would the esr be null since I don't see any mention of when it will be added there? Also for the ui_category I was thinking it would fall under privacy, is that correct?

@cadeyrn

This comment has been minimized.

Copy link
Owner Author

@cadeyrn cadeyrn commented Oct 20, 2019

@varshannagarajan:

Yes, if the ESR version is still unknown or if the policy won't be supported in Firefox ESR then the esr property has to be set to null. But in this case we don't want to add a new policy. Instead a new property has to be added to an already existing policy, the SearchEngines policy.

The SearchEngines policy already has a Default property and the new DefaultPrivate property should be added below this property because it's exactly the same but for private instead for regular browser windows (a seperate search for private windows is a new feature of Firefox 71 and won't be included in Firefox ESR 68).

You can copy the Default property and use policy_description_SearchEngines_DefaultPrivate as key for the translation. The translation should be "Name of the default search engine for private windows if different than for regular windows (Firefox 71+)" - we have to add the Firefox version to the translation because the policy is supported since Firefox 60 and only this property is new in Firefox 71.

varshannagarajan added a commit to varshannagarajan/enterprise-policy-generator that referenced this issue Oct 29, 2019
cadeyrn added a commit that referenced this issue Dec 7, 2019
fixed issue #111 added DefaultPrivate property to SearchEngines policy
@cadeyrn cadeyrn assigned cadeyrn and varshannagarajan and unassigned cadeyrn Dec 7, 2019
@cadeyrn cadeyrn closed this Dec 7, 2019
@cadeyrn cadeyrn modified the milestones: Version 6.0.0, Version 5.1.0 Dec 7, 2019
cadeyrn added a commit that referenced this issue Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.