Introducing ConnectionFactory #2

Merged
merged 3 commits into from Feb 17, 2017

Projects

None yet

2 participants

@andrewshell
Contributor

An attempt at solving issue #1 (Support multiple connections).

+ } elseif ($dsn instanceof PDO) {
+ $this->pdo = new ExtendedPdo(new TraceablePDO($dsn));
+ } else {
+ $this->dsn = $dsn;
@harikt
harikt Oct 17, 2016

Why not create the instance here ?

Reason : It is any how lazy loaded. Also I don't know if we really need these much of configuration option. But I know different people, different configuration. But a bit complex.

@harikt
harikt commented Oct 17, 2016

Give me some time, I need to look more closely into this.

Late night :) .

@andrewshell andrewshell merged commit 253321e into 1.x Feb 17, 2017
@andrewshell andrewshell deleted the 1.x-connection-factory branch Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment