Lance Ivy cainlevy

Organizations

@kickstarter
@cainlevy
options for a more reliable Scheduled::Poller
cainlevy commented on issue mperham/sidekiq#2317
@cainlevy

long live Sidekiq.average_scheduled_poll_interval

cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

i think all feedback has been addressed here. do let me know if anything else stands out.

@cainlevy
  • @cainlevy a382cb9
    final name: average_scheduled_poll_interval
cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

Oh sure, will do. When I'm learning a new library, I like to see what the options are. Sidekiq has bits and pieces of advice throughout the wiki, b…

cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

No rush. I probably won't get back to Sidekiq this week myself.

cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

brainstorming names: future_jobs_check_delay average_checkin_for_dated_jobs scheduled_jobs_accuracy run_at_jobs_poll_interval mix and match: run…

@cainlevy
cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

nice. much simpler.

cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

squashed tests into the commit. i ended up tuning the iterations and delta so it wouldn't throw random errors when i looped the whole test 200.times.

@cainlevy
  • @cainlevy 4255aaf
    make the average global poller delay configurable
@cainlevy
  • @cainlevy 925146a
    test coverage for poller's interval logic
cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

oh, i meant to observe out that if anyone is setting Sidekiq.options[:poll_interval] directly without using Sidekiq.poll_interval=, this change won…

cainlevy commented on pull request mperham/sidekiq#2322
@cainlevy

:+1:

@cainlevy
  • @cainlevy c8b755b
    make the average global poller delay configurable
  • @mperham 1825f28
    Merge pull request #2323 from kickstarter/smaller_random_poll_interva…
  • 1 more commit »
cainlevy opened pull request mperham/sidekiq#2323
@cainlevy
calculate each poll interval in a tighter range with the same average
1 commit with 8 additions and 6 deletions
@cainlevy
  • @cainlevy add012a
    calculate each poll interval in a tighter range with the same average
cainlevy opened pull request mperham/sidekiq#2322
@cainlevy
make the average global poller delay configurable
1 commit with 20 additions and 10 deletions
cainlevy commented on issue mperham/sidekiq#2317
@cainlevy

If you're running 10 Sidekiq processes and want to check every 5 seconds on average, set poll_interval to 50 and you should see more predictable b…

cainlevy commented on issue mperham/sidekiq#2317
@cainlevy

@mperham Agreed that electing a single Poller is a lot of complexity for the problem. It sounds cool, but not pragmatic. That's why I'd be happy to…

cainlevy commented on issue mperham/sidekiq#2317
@cainlevy

@jonhyman Nice. Can you share what interval and number of pollers you're currently running?

@cainlevy
options for a more reliable Scheduled::Poller
@cainlevy
@cainlevy