Cast offset to bignum when constructing a new Consumer. #26

Merged
merged 2 commits into from Jan 10, 2013

Conversation

Projects
None yet
2 participants
@ctavan
Contributor

ctavan commented Jan 10, 2013

  • If a non-bignum offset gets set in the constructor, the consumer will never
    fetch a single message.

There should probably a test covering this behavior but I'm not so sure how this should be done since as far as I understand Kafka is entirely mocked in the test-suite. So it's rather difficult to account for every aspect.

ctavan added some commits Jan 10, 2013

Cast offset to bignum when constructing a new Consumer.
- If a non-bignum offset gets set in the constructor, the consumer will never
  fetch a single message.

cainus added a commit that referenced this pull request Jan 10, 2013

Merge pull request #26 from ctavan/typecast-offset-to-bignum
Cast offset to bignum when constructing a new Consumer.

@cainus cainus merged commit 12b38df into cainus:master Jan 10, 2013

1 check passed

default The Travis build passed
Details
@cainus

This comment has been minimized.

Show comment
Hide comment
@cainus

cainus Jan 10, 2013

Owner

Looks good. Thanks!

Owner

cainus commented Jan 10, 2013

Looks good. Thanks!

@ctavan ctavan deleted the ctavan:typecast-offset-to-bignum branch Jan 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment