Fixed a bug that crashes iTerm when a profile is deleted.

git-svn-id: https://iterm.svn.sourceforge.net/svnroot/iterm/trunk@1640 a86d2aa4-6e2d-4ff4-9c10-3c044852e7c9
caius · Sep 19, 2008 · 6a799ba · 6a799ba
1 parent 73c9495
commit 6a799ba
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/Changelog b/Changelog
@@ -7,6 +7,7 @@
     * Minor UI change: Added shortcut key for menu Reset and Return to Default Size.
     * UI change: Double-clicking the tab bar now launches new tab.
     * UI change: Double-clicking the key-binding list now opens the edit sheet.
+    * Fixed a bug that crashes iTerm when a profile is deleted.
 
 2008-09-17  fabian
 

diff --git a/iTermDisplayProfileMgr.m b/iTermDisplayProfileMgr.m
@@ -184,8 +184,8 @@ - (void) deleteProfileWithName: (NSString *) profileName
 	if([profileName length] <= 0)
 		return;
 
-	[profiles removeObjectForKey: profileName];
 	[self updateBookmarkProfile: profileName with:@"Default"];
+	[profiles removeObjectForKey: profileName];
 }
 
 - (BOOL) isDefaultProfile: (NSString *) profileName

diff --git a/iTermKeyBindingMgr.m b/iTermKeyBindingMgr.m
@@ -153,8 +153,8 @@ - (void) deleteProfileWithName: (NSString *) aString
 {
 	if([aString length] > 0)
 	{
-		[profiles removeObjectForKey: aString];
 		[self updateBookmarkProfile: aString with:@"Default"];
+		[profiles removeObjectForKey: aString];
 	}
 }
 

diff --git a/iTermTerminalProfileMgr.m b/iTermTerminalProfileMgr.m
@@ -155,8 +155,8 @@ - (void) deleteProfileWithName: (NSString *) profileName
 	if([profileName length] <= 0)
 		return;
 
-	[profiles removeObjectForKey: profileName];
 	[self updateBookmarkProfile: profileName with:@"Default"];
+	[profiles removeObjectForKey: profileName];
 }
 
 - (BOOL) isDefaultProfile: (NSString *) profileName