Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for overriding the location of cake.exe the TRX uses #105

Merged
merged 1 commit into from Mar 21, 2019

Conversation

agc93
Copy link
Member

@agc93 agc93 commented Mar 21, 2019

This basically just allows us to use a relative path that's not tools/Cake to find cake.exe in.

I've deliberately over-engineered this because I'm 95% certain we're still missing some edge cases and I'd like to be able to add an option for a fixed/absolute location later as well.

@agc93 agc93 added this to the 0.3.0 milestone Mar 21, 2019
@agc93 agc93 requested a review from gep13 March 21, 2019 18:09
Signed-off-by: Alistair Chapman <alistair@cakebuild.net>
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agc93 agc93 merged commit 7378694 into cake-build:develop Mar 21, 2019
@agc93 agc93 deleted the feature/gh-79 branch March 21, 2019 19:00
@gep13 gep13 added the Feature label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants