New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dotCover configuration file #1401

Closed
matkoch opened this Issue Dec 8, 2016 · 13 comments

Comments

Projects
None yet
7 participants
@matkoch

matkoch commented Dec 8, 2016

As described in the help, dotCover can also be called with a configuration file:

dotCover cover <configuration file name> [parameters]

I guess this is especially interesting for specifying filters. Since they might be reused from within the IDE at some point.

@gep13

This comment has been minimized.

Member

gep13 commented Dec 8, 2016

@matkoch this sounds like a very useful addition. Are you interested in sending a PR to implement this?

@mholo65

This comment has been minimized.

Member

mholo65 commented Dec 21, 2016

Quickly checking, the settings param should be added to the abstract DotCoverSettings class and make it available to all DotCover aliases.

If @matkoch is not in a position to send a PR, I could send one when I have time (beginning of January)..

@B3nCr

This comment has been minimized.

B3nCr commented Mar 13, 2018

Did anyone do anything with this? I'm guessing not as I can't see it.

@gep13

This comment has been minimized.

Member

gep13 commented Mar 13, 2018

@B3nCr no, not that I am aware of. We would be happy to accept a PR if this is something you are interested in seeing getting added.

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Mar 31, 2018

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Apr 4, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Apr 4, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401
@AdaskoTheBeAsT

This comment has been minimized.

Contributor

AdaskoTheBeAsT commented Apr 9, 2018

I already added PR
@gep13 could you please review my changes?

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Apr 21, 2018

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Apr 21, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Apr 21, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401
@asci13

This comment has been minimized.

asci13 commented Jul 16, 2018

This would be great to have, is there any news on merging the PR?

@devlead

This comment has been minimized.

Member

devlead commented Jul 16, 2018

@asci13 Looks like issuer closed the PR #2108, and a new one hasn't been opened. Unsure if it's up for grabs or if @AdaskoTheBeAsT is planning to open a new PR.

@gep13

This comment has been minimized.

Member

gep13 commented Jul 16, 2018

@devlead the source branch is still there, I "think" it just needs another rebase. I was actually just away to look into it... Will report back on what I find.

@gep13

This comment has been minimized.

Member

gep13 commented Jul 16, 2018

Doh! Looks like @AdaskoTheBeAsT hasn't allowed pushing back to his repository. So even though I have rebased the changes onto the latest develop branch, I can't push them back to his repo. I could rebase/merge directly, but we would lose the CI checks prior to merging 😢

@devlead

This comment has been minimized.

Member

devlead commented Jul 16, 2018

Permission disappeared when PR closed, unfortunately GitHub won't allow you to reopen a PR , you could push branch to your personal repo and open new PR, original issuer would still get attribution for the commit.

@gep13

This comment has been minimized.

Member

gep13 commented Jul 16, 2018

@devlead interesting idea. I will see what I can do over lunch time.

@AdaskoTheBeAsT

This comment has been minimized.

Contributor

AdaskoTheBeAsT commented Jul 16, 2018

Hi, sorry i am away for 3 weeks vacation. Feel free to grab code.

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Jul 19, 2018

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Jul 19, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Jul 19, 2018

Support for DotCover configuration file added - fixes cake-build#1401
Support for DotCover configuration file added - fixes cake-build#1401

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Jul 19, 2018

@AdaskoTheBeAsT

This comment has been minimized.

Contributor

AdaskoTheBeAsT commented Jul 19, 2018

Hi I found some time on vacation to properly rebase branch and squash - now in pull #2213

AdaskoTheBeAsT added a commit to AdaskoTheBeAsT/cake that referenced this issue Jul 26, 2018

devlead added a commit to AdaskoTheBeAsT/cake that referenced this issue Aug 14, 2018

devlead added a commit that referenced this issue Aug 14, 2018

Merge branch 'AdaskoTheBeAsT-feature/Support-for-dotCover-configurati…
…on-file' into develop

* AdaskoTheBeAsT-feature/Support-for-dotCover-configuration-file:
  Support for DotCover configuration file added - fixes #1401

@devlead devlead added this to the v0.30.0 milestone Aug 14, 2018

devlead added a commit that referenced this issue Aug 22, 2018

Merge branch 'release/0.30.0' into main
* release/0.30.0: (22 commits)
  (build) Updated version and release notes.
  (GH-2214) Use Environment.CommandLine directly and remove polyfill.
  (GH-2238) Add repository metadata to NuGet packages
  Added alias for checking if the current run is a dry run.
  Execute setup and teardown when dry running script.
  (GH-2233) Documented bootstrap argument
  (GH-2232) Document exclusive argument
  (GH-2234) Removed Mono from CakeOption
  Add XML comments for CakeTaskExtensions
  Fix CakeTaskExtensions accessibility
  (build) Change tool name & fix packaging
  (build) Added Cake.Tool package to parameters.cake
  Allow opting out from using working directory.
  (GH-2067) Cake .NET Core Tool package * Updates SDK * Addes Cake.Tool project * Fixes #2067 * Fixes #1644
  Support for DotCover configuration file added - fixes #1401
  Initialized all tool settings collection properties
  Failing tests for initialized tool settings collections
  (GH-2207) Update to NuGet 4.7.0
  (GH-2220) Corrected documentation for InnoSetup alias
  (doc) Minor modification
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment