Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
MSBuild property values should escape carriage return and line feed #1910
Without escaping these, there's no way to set a multiline property value such as
I saw that you're doing URL encoding when semicolons are present and indeed, the same trick works for CRLF:
var releaseNotes = ParseReleaseNotes("./ReleaseNotes.md").Notes; MSBuild(BuildParameters.ProjectDir, new MSBuildSettings() .WithTarget("Pack") .WithProperty("PackageReleaseNotes", string.Join("%0D%0A", releaseNotes)));
However, I shouldn't be URL-encoding myself- what if one of the lines contains a semicolon? Then it probably gets URL-encoded again by Cake, breaking the manually-URL-encoded newlines.
We should be able to do