New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitVersion is missing AssemblySemFileVer #1922

Closed
Cheesebaron opened this Issue Nov 20, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@Cheesebaron
Contributor

Cheesebaron commented Nov 20, 2017

What You Are Seeing?

Running GitVersion something like this is output when using Json format:

{
  "Major":7,
  "Minor":0,
  "Patch":0,
  "PreReleaseTag":"derp.1",
  "PreReleaseTagWithDash":"-derp.1",
  "PreReleaseLabel":"derp",
  "PreReleaseNumber":1,
  "BuildMetaData":168,
  "BuildMetaDataPadded":"0168",
  "FullBuildMetaData":"168.Branch.derp.Sha.8a5702d448332a5d7563f86d30954b1543e85817",
  "MajorMinorPatch":"7.0.0",
  "SemVer":"7.0.0-derp.1",
  "LegacySemVer":"7.0.0-derp1",
  "LegacySemVerPadded":"7.0.0-derp0001",
  "AssemblySemVer":"",
  "AssemblySemFileVer":"7.0.0.1",
  "FullSemVer":"7.0.0-derp.1+168",
  "InformationalVersion":"7.0.0-derp.1+168.Branch.derp.Sha.8a5702d448332a5d7563f86d30954b1543e85817",
  "BranchName":"derp",
  "Sha":"8a5702d448332a5d7563f86d30954b1543e85817",
  "NuGetVersionV2":"7.0.0-derp0001",
  "NuGetVersion":"7.0.0-derp0001",
  "NuGetPreReleaseTagV2":"derp0001",
  "NuGetPreReleaseTag":"derp0001",
  "CommitsSinceVersionSource":168,
  "CommitsSinceVersionSourcePadded":"0168",
  "CommitDate":"2017-11-20"
}

However, the GitVersion class does not contain the definition for AssemblySemFileVer

What is Expected?

AssemblySemFileVer to be present. Needs to be added to the class so it can be deserialized.

What version of Cake are you using?

Latest 0.23.0

Are you running on a 32 or 64 bit system?

64

What environment are you running on? Windows? Linux? Mac?

Win 10

@devlead devlead added the Improvement label Nov 28, 2017

@devlead devlead added this to the v0.24.0 milestone Nov 28, 2017

devlead added a commit that referenced this issue Nov 28, 2017

Merge branch 'Cheesebaron-feature/GH-1922' into develop
* Cheesebaron-feature/GH-1922:
  Add AseemblySemFileVer to GitVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment