New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetPackSettings.Properties does not support whitespaces. #1933

Closed
robsammons opened this Issue Nov 27, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@robsammons
Contributor

robsammons commented Nov 27, 2017

What You Are Seeing?

Issue using "Properties" field on NuGetPackSettings. the properties are not being enclosed in " when being resolved into a command line
i.e.

pack "/Working/existing.csproj" -Properties Configuration=Release;Foo=Bar

Should be

pack "/Working/existing.csproj" -Properties "Configuration=Release;Foo=Bar"

What is Expected?

pack "/Working/existing.csproj" -Properties "Configuration=Release;Foo=Bar"

What version of Cake are you using?

0.23.0

Are you running on a 32 or 64 bit system?

64-bit

What environment are you running on? Windows? Linux? Mac?

Windows

How Did You Get This To Happen? (Steps to Reproduce)

Created "NuGetPack" with NuGetPackSettings.Properties used.

Currently forcing the quotes into my build code as a work around i.e.

var nuGetPackSettings = new NuGetPackSettings
    {
        Version = version,
        BasePath = nugetPackageDir,
        OutputDirectory = nugetPackageDir,
        Properties = new Dictionary<string, string>()
        {
            {"\"buildinfo", $"Build branch {branchName}"},
            {"result", buildResultsUrl + "\""}
        }
    };

robsammons pushed a commit to robsammons/cake that referenced this issue Nov 27, 2017

robsammons pushed a commit to robsammons/cake that referenced this issue Dec 3, 2017

OZFOREX\sammoro
Fix for issue cake-build#1933. NuGetPackSettings.Properties not resol…
…ving to correct output on command line

Change NuGetPackSettings fix to use AppendQuoted

robsammons added a commit to robsammons/cake that referenced this issue Dec 3, 2017

Fix for issue cake-build#1933. NuGetPackSettings.Properties not resol…
…ving to correct output on command line

Change NuGetPackSettings fix to use AppendQuoted
@RaringCoder

This comment has been minimized.

Show comment
Hide comment
@RaringCoder

RaringCoder Dec 8, 2017

I just ran into this issue and manually wrapping the first argument and the last parameter in quotes as detailed here did the trick. Easy thing to get fixed too.

RaringCoder commented Dec 8, 2017

I just ran into this issue and manually wrapping the first argument and the last parameter in quotes as detailed here did the trick. Easy thing to get fixed too.

@mholo65 mholo65 added this to the v0.24.0 milestone Dec 11, 2017

@mholo65 mholo65 added the Bug label Dec 11, 2017

@mholo65 mholo65 changed the title from Failed NugetPack when using NuGetPackSettings.Properties to NuGetPackSettings.Properties does not support whitespaces. Dec 11, 2017

mholo65 added a commit to robsammons/cake that referenced this issue Dec 11, 2017

Fix for issue cake-build#1933. NuGetPackSettings.Properties not resol…
…ving to correct output on command line

Change NuGetPackSettings fix to use AppendQuoted

@mholo65 mholo65 closed this in 74211e9 Dec 11, 2017

CRuppert added a commit to CRuppert/cake that referenced this issue Jan 23, 2018

Fix for issue cake-build#1933. NuGetPackSettings.Properties not resol…
…ving to correct output on command line

Change NuGetPackSettings fix to use AppendQuoted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment