New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - TypeExtensions.GetFullName doesn't handle nested types correctly #1939

Closed
kcamp opened this Issue Nov 30, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kcamp
Collaborator

kcamp commented Nov 30, 2017

While fixing GH-1930 the other night, some of the tests for ParameterEmitter caught my eye (seemed to be asserting the wrong "expected" values). With fresh eyes, I wrote some red/green tests against the MethodAliasGenerator to prove what I was seeing was in fact wrong.

What You Are Seeing?

The code generation for some nested types is being emitted with the + sign in the type name. i.e., My.Namespace.ParentType+NestedType.

Upon reviewing the code, I see that some of the work I did for GH-1566 accounted for this (presence of +) in the GenericParameterConstraintEmitter implementation; this should have rightfully been made part of the TypeExtensions.GetFullName extension method, instead.

What is Expected?

Valid, compilable code to be emitted for all types via the TypeExtensions.GetFullName method.

What version of Cake are you using?

0.23

I will have a PR for this shortly.

devlead added a commit that referenced this issue Nov 30, 2017

Merge branch 'kcamp-GH-1939' into develop
* kcamp-GH-1939:
  Fix GH1939: This corrects the implementation of GetFullName to provide syntactically correct string values for nested types.

@devlead devlead added the Bug label Nov 30, 2017

@devlead devlead added this to the v0.24.0 milestone Nov 30, 2017

@devlead

This comment has been minimized.

Show comment
Hide comment
@devlead

devlead Nov 30, 2017

Member

Fixed by #1940

Member

devlead commented Nov 30, 2017

Fixed by #1940

@devlead devlead closed this Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment