Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSWhere -requires and -products argument values are quoted but VSWhere doesn't support multiple values in quotes #2088

Closed
sean-rose opened this Issue Mar 16, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@sean-rose
Copy link
Contributor

commented Mar 16, 2018

What You Are Seeing?

Cake's VSWhere aliases put quotes around the -requires and -products argument values, which are supposed to allow multiple workloads/products to be specified, but per Microsoft/vswhere#141 VSWhere doesn't support passing multiple workloads/products within one quoted argument value.

What is Expected?

Cake's VSWhere aliases should not put quotes around the -requires and -products argument values in order to allow multiple workloads/products to be specified.

What version of Cake are you using?

0.26.1

What environment are you running on? Windows? Linux? Mac?

Windows

How Did You Get This To Happen? (Steps to Reproduce)

This code:

DirectoryPath vs = VSWhereLatest(new VSWhereLatestSettings
{
    Requires = "Microsoft.Component.MSBuild Microsoft.VisualStudio.PackageGroup.TestTools.Core"
});

currently ends up running something like

vswhere -latest -requires "Microsoft.Component.MSBuild Microsoft.VisualStudio.PackageGroup.TestTools.Core"

which will never return anything due to VSWhere treating the entire -requires argument value as a single workload ID.

Similarly, code like VSWhereProducts("X Y") currently ends up running something like vswhere -products "X Y" which will never return anything because VSWhere looks for the product ID "X Y" rather than "X" and "Y" separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.