New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip should behave by default like standard Zip utilities #2381

Closed
gitfool opened this Issue Dec 8, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@gitfool
Copy link
Contributor

gitfool commented Dec 8, 2018

Specifically, the following subtle but very important behaviors are expected:

  • Directories should be stored as zip entries
  • Empty directories should be included

For example, consider the following directory structure:

  • Root/
    • Root.txt
    • Empty/
    • First/
      • First.txt
      • Nested/
        • Nested.txt

When archived by Cake Zip it looks like the following (using the flat view in 7-Zip):

image

When archived by Windows built-in zip, 7-Zip, WinZip, and WinRAR, it looks like the following:

image

Only the file compression method differs between the various utilities; some will Store them rather then Deflate them, depending on compression level. Note that all directories are stored, including empty directories.

As trivial as it sounds, I really need this behavior, without needing another dependency. PR incoming! 😉

@gitfool

This comment has been minimized.

Copy link
Contributor

gitfool commented Dec 10, 2018

When archived by Cake Zip, using PR #2382, it looks like the following:

image

Note: the timestamps are now correct too! 😉

@devlead devlead added the Improvement label Dec 20, 2018

@devlead devlead added this to the v0.32.0 milestone Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment