New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFBuildCommand PublishCodeCoverage API Changes #2412

Closed
RLittlesII opened this Issue Dec 23, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@RLittlesII
Copy link
Collaborator

RLittlesII commented Dec 23, 2018

What You Are Seeing?

Currently the public API for this command doesn't support passing in the primary file. It also uses string instead of FilePath and DirectoryPath for elements that are expected to be file paths

        public string SummaryFileLocation { get; set; }
        public string ReportDirectory { get; set; }
        public string[] AdditionalCodeCoverageFiles { get; set; }

What is Expected?

        public FilePath SummaryFileLocation { get; set; }
        public DirectoryPath ReportDirectory { get; set; }
        public FilePath[] AdditionalCodeCoverageFiles { get; set; }

A public API method that exposes the primary file location

PublishCodeCoverage(FilePath SummaryFileLocation, TFBuildPublishCodeCoverageData data)

Lastly the GetProperties method only works for Windows. It requires a similar change documented #2339

properties.Add("summaryfile", new FilePath(SummaryFileLocation).MakeAbsolute(environment).FullPath.Replace("/", "\\"));

What version of Cake are you using?

Cake Version 0.30.0

Are you running on a 32 or 64 bit system?

64 Bit

What environment are you running on? Windows? Linux? Mac?

Mac

Are you running on a CI Server? If so, which one?

Azure Dev Ops

This issue is related to #2337

RLittlesII added a commit to RLittlesII/cake that referenced this issue Dec 28, 2018

(cake-buildGH-2412) Added PublishCodeCoverage overloads
- Added PublishCodeCoverage overloads
- Fixed System.IO.Path.DirectorySeparatorChar

RLittlesII added a commit to RLittlesII/cake that referenced this issue Dec 28, 2018

(cake-buildGH-2412) Added PublishCodeCoverage overloads
- Added PublishCodeCoverage overloads
- Fixed System.IO.Path.DirectorySeparatorChar

devlead added a commit to RLittlesII/cake that referenced this issue Dec 30, 2018

(cake-buildGH-2412) Added PublishCodeCoverage overloads
- Added PublishCodeCoverage overloads
- Fixed System.IO.Path.DirectorySeparatorChar

@devlead devlead added the Improvement label Dec 30, 2018

@devlead devlead added this to the v0.32.0 milestone Dec 30, 2018

devlead added a commit that referenced this issue Dec 30, 2018

Merge branch 'RLittlesII-GH2412' into develop
* RLittlesII-GH2412:
  (GH-2412) Added PublishCodeCoverage overloads

devlead added a commit that referenced this issue Jan 4, 2019

Merge branch 'release/0.32.0' into main
* release/0.32.0: (26 commits)
  (build) Updated version and release notes.
  Added support for MSBuild16.
  (maint) tabs to spaces
  Add ResultsDirectory to DotNetCoreVSTestSettings * Improve DotNetCoreVSTest documentation * fixes #2243
  (GH-1973) added Products to VSWhereLatestSettings * fixes #1973
  Adds /sm argument to SignTool
  (GH-2337) Fix TFBuildCommand Directory Separator Character
  (doc) Corrected test method names
  (GH-2419) Add token parameters to GitReleaseManager
  (GH-2420) Added new label alias for GitReleaseManager
  (GH-2410) T4 Global tool support * Adds t4 & t4.exe for tool resolution * Adds Properties & Class to TextTransformSettings * Integration tests for TransformTemplate * Fixes #2410
  (GH-2412) Added PublishCodeCoverage overloads
  (GH-2417) Add additional Tool names for GitReleaseManager
  (build) Update addins&tools,refactor bootstrappers * Switch to Cake.Tool * Update addins & tools, switch to global tools where available * Update to .NET Core SDK 2.1.502 * Rewritten bootstrappers     * Reduce Cake & .NET Core SDK verson from 3 to 2 places (global.json, build.ps1, build.sh -> global.json, build.config)      * Use Cake standard command line parameters (build.ps1 / build.sh called the same way)      * Don't install Cake if same version is installed globally      * Don't install .NET Core if same version installed globally * Start utilizing Cake official containers
  Implement standard zip behavior by default
  Add an Encoding parameter to TextTransformation.Save
  GH2294: Add fluent API to enable MSBuild binary logger
  (GH-2403) Use Mono 5.12.0 on Travis * Fixes #2403
  add missing report types
  Fix nuspec generation when collections are empty instead of null
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment