Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSBuild options to enable RestoreLockedMode #2415

Closed
SIkebe opened this Issue Dec 28, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@SIkebe
Copy link
Contributor

commented Dec 28, 2018

Recently NuGet introduced packages.lock.json to enable repeatable package restore and added options to enable locked mode.
https://blog.nuget.org/20181217/Enable-repeatable-package-restores-using-a-lock-file.html

dotnet.exe restore --locked-mode
msbuild.exe /t:restore /p:RestoreLockedMode=true

It'd be great if Cake support those options natively.

@devlead

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

@SIkebe agreed, marking as up for grabs 👍
Sidenote, remarks on property should be documented minimal supported MSBuild / .NET CLI version.

  • Visual Studio 2017 version 15.9 and above.
  • .NET SDK version 2.1.500 and above.
@fseegraeber

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2019

I'd be happy to take a look at this if it's ok.

We're talking about extending MSBuildSettings and MSBuildSettingsExtensions right?

@devlead

This comment has been minimized.

Copy link
Member

commented Jan 4, 2019

@fseegraeber sure go ahead, I'll remove up-for-grabs / help wanted tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.