Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundhouse dotnet tool does not run #2465

Closed
Roemer opened this Issue Feb 2, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@Roemer
Copy link
Contributor

commented Feb 2, 2019

What You Are Seeing?

Using the Roundhouse .Net Core tool with DotNetCoreTool does not work as it says No executable found matching command "dotnet-roundhouse. This is probably as the Roundhouse .Net Core tool is installed as rh and the alias that is created in the cake folder is rh.ex.

What is Expected?

The tool should run correctly.

What version of Cake are you using?

0.32.1

Are you running on a 32 or 64 bit system?

64

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

  1. Create a new cake project.
  2. Add #module nuget:?package=Cake.DotNetTool.Module
  3. Run build.ps1 --bootstrap
  4. Add #tool dotnet:?package=dotnet-roundhouse
  5. Run DotNetCoreTool("roundhouse"); from any cake task.
@gep13

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@Roemer I have just created a PR that should address this for you.

@Roemer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

I'm fairly unsure if this is the correct way around.
When installing the .Net Core Roundhouse, I get the tool installed into:

<cake folder>\.store\dotnet-roundhouse\1.0.3\dotnet-roundhouse\1.0.3\tools\netcoreapp2.1\any

and inside is an rh and rh.bat file.
Additionally in the <cake folder> is a "shim" called rh.exe. There is no dotnet-roundhouse or dotnet-roundhouse.exe except for in the folder name. Would your fix still fix that issue?

@gep13

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@Roemer hmm, I had made an assumption based on the name of the package. Having just attempted the installation of this global tool, I can see that this PR isn't going to work as it currently stands.

@gep13

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@Roemer actually, this should already work for you....

Try the following:

image

There should be no need to run DotNetCoreTool("roundhouse");

gep13 added a commit to gep13/cake that referenced this issue Feb 2, 2019

@gep13

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

@Roemer I have updated the PR to include only the shims that are created as part of the dotnet tool installation, i.e. rh.exe and rh.

As I mentioned though, for you, on Windows, this should already work today:

image

@Roemer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

@gep13 Hmm yes it works now. I think I first tried to use the nuget package (tool nuget:?package=roundhouse) which did not work for me because there was a bug in the executable so I tried using the .net core tool (which worked). For some reason I had to add ToolPath = Context.Tools.Resolve("rh.exe") to RoundhouseSettings but now it seems to work correctly. Probably because I now have deinstalled the nuget tool and only installed the .Net Core tool.

devlead added a commit to gep13/cake that referenced this issue Feb 19, 2019

devlead added a commit that referenced this issue Feb 19, 2019

Merge branch 'gep13-feature/GH-2465' into develop
* gep13-feature/GH-2465:
  (GH-2465) Add additional tool names for Roundhouse

@devlead devlead added the Improvement label Feb 19, 2019

@devlead devlead added this to the v0.33.0 milestone Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.