Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNet commands do not respect the verbosity #2468

Closed
Roemer opened this Issue Feb 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Roemer
Copy link
Contributor

commented Feb 6, 2019

As the title says, the DotNetCommands do not respect the verbosity setting. The problem seems to be that the verbosity expects a lowercase text (see https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet?tabs=netcore21) but cake just uses the Enum.ToString().
I will create a PR which adds a ToLower().

@Roemer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

Can be verified like this:

var settings = new DotNetCoreTestSettings
{
    Verbosity = DotNetCoreVerbosity.Normal,
};
// This won't print out the tests that are executed
DotNetCoreTest("some.dll", settings);
var settings = new DotNetCoreTestSettings
{
    ArgumentCustomization = args=>args.Append("-v=normal")
};
// This will print out the tests that are executed
DotNetCoreTest("some.dll", settings);

@devlead devlead added this to the v0.33.0 milestone Feb 20, 2019

@devlead devlead added the Bug label Feb 20, 2019

devlead added a commit that referenced this issue Feb 20, 2019

Merge branch 'Roemer-bugfix/GH2468-DotNetVerbosity' into develop
* Roemer-bugfix/GH2468-DotNetVerbosity:
  (GH-2468) Convert the DotNetCoreVerbosity to lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.