Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Azure DevOps (TFBuild) properties #2491

Closed
flcdrg opened this Issue Feb 27, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@flcdrg
Copy link
Contributor

commented Feb 27, 2019

There's a few missing properties on the TFBuild classes for Azure DevOps Pipeline build variables, documented in https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml

Working on a PR to add these in

@flcdrg

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

I just noticed that @gitfool has done a couple of these recently (eg. Reason)

@gitfool

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

I was more focused on laying the foundation for identifying a pull request, across multiple providers, rather than capturing every last detail.

You can double check against this PR build on Azure Pipelines to confirm all the environment variables and what the actual values look like.

@flcdrg

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Probably good timing then that I come after your commit and can add on to your work, given you've looked at the other providers as well.

👍

@devlead devlead added the Improvement label Feb 28, 2019

@devlead devlead added this to the v0.33.0 milestone Feb 28, 2019

@devlead

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

fixed by #2492

@devlead devlead closed this Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.