Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.ps1 fails in non-English culture because of the culture sensitive test #2541

Closed
SIkebe opened this issue Apr 29, 2019 · 3 comments
Closed
Labels
Milestone

Comments

@SIkebe
Copy link
Contributor

@SIkebe SIkebe commented Apr 29, 2019

What You Are Seeing?

.\build.ps1 in this repo fails to execute.

What is Expected?

.\build.ps1 executes without error.

What version of Cake are you using?

Latest

Are you running on a 32 or 64 bit system?

64bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

Clone this repo and execute .\build.ps1 under the repository root.
Test fails here.

var ex = Record.Exception(() => EnvironmentAliases.EnvironmentVariable(context, TestVariableName, 456));
// Then
Assert.NotNull(ex);
Assert.Contains("not a valid value", ex.Message);

Output Log

PS C:\GitHub\cake> .\build.ps1
.
.
.
[xUnit.net 00:00:03.6363220]     Cake.Common.Tests.Unit.EnvironmentAliasesTests+TheEnvironmentVariableMethod.Should_Throw_If_Value_Does_Not_Convert [FAIL]
失敗   Cake.Common.Tests.Unit.EnvironmentAliasesTests+TheEnvironmentVariableMethod.Should_Throw_If_Value_Does_Not_Convert
エラー メッセージ:
 Assert.Contains() Failure
Not found: not a valid value
In value:  abc は Int32 の有効な値ではありません。
スタック トレース:
   場所 Cake.Common.Tests.Unit.EnvironmentAliasesTests.TheEnvironmentVariableMethod.Should_Throw_If_Value_Does_Not_Convert() 場所 C:\GitHub\cake\src\Cake.Common.Tests\Unit\EnvironmentAliasesTests.cs:行 165
Results File: C:/GitHub/cake/artifacts/v0.34.0-alpha0012/test-results/Cake.Common.Tests_full_TestResults_2019-04-29_15-30-42-489.xml

テストの合計数: 3897。成功: 3896。失敗:1。スキップ: 0。
テストの実行に失敗しました。
テスト実行時間: 5.1722 秒
An error occurred when executing task 'Run-Unit-Tests'.

----------------------------------------
Teardown
----------------------------------------
Starting Teardown...
Finished running tasks.
Error: One or more errors occurred. (.NET Core CLI: Process returned an error (exit code 1).)
        .NET Core CLI: Process returned an error (exit code 1).
@drakegens

This comment has been minimized.

Copy link

@drakegens drakegens commented May 1, 2019

I might take a stab at this one. Any context as I am first time contributor to this project would be appreciated! Including if this would be a good first issue to tackle.

@mholo65 mholo65 added the Build label Nov 20, 2019
@mholo65 mholo65 added this to the v0.36.0 milestone Nov 20, 2019
@devlead

This comment has been minimized.

Copy link
Member

@devlead devlead commented Dec 9, 2019

Fixed by #2651

@devlead devlead closed this Dec 9, 2019
@SIkebe

This comment has been minimized.

Copy link
Contributor Author

@SIkebe SIkebe commented Dec 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.