Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCoreTestSettings: Missing RunTime Property which is needed for RID builds #2556

Closed
TraGicCode opened this issue May 21, 2019 · 3 comments

Comments

Projects
None yet
5 participants
@TraGicCode
Copy link

commented May 21, 2019

DotNetCoreTestSettings is missing the RunTime Property which is needed for RID builds Or atleast.

https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/DotNetCore/Test/DotNetCoreTestSettings.cs

╰─ dotnet test --help
Usage: dotnet test [options] <PROJECT> [[--] <RunSettings arguments>...]]

Arguments:
  <PROJECT>   The project file to operate on. If a file is not specified, the command will search the current directory for one.

Options:
  -h, --help                               Show command line help.
  -s, --settings <SETTINGS_FILE>           The settings file to use when running tests.
  -t, --list-tests                         List the discovered tests instead of running the tests.
  --filter <EXPRESSION>                    Run tests that match the given expression.
                                           Examples:
                                           Run tests with priority set to 1: --filter "Priority = 1"
                                           Run a test with the specified full name: --filter "FullyQualifiedName=Namespace.ClassName.MethodName"
                                           Run tests that contain the specified name: --filter "FullyQualifiedName~Namespace.Class"
                                           See https://aka.ms/vstest-filtering for more information on filtering support.

  -a, --test-adapter-path <ADAPTER_PATH>   The path to the custom adapters to use for the test run.
  -l, --logger <LOGGER>                    The logger to use for test results.
                                           Examples:
                                           Log in trx format using a unique file name: --logger trx
                                           Log in trx format using the specified file name: --logger "trx;LogFileName=<TestResults.trx>"
                                           See https://aka.ms/vstest-report for more information on logger arguments.
  -c, --configuration <CONFIGURATION>      The configuration to use for running tests. The default for most projects is 'Debug'.
  -f, --framework <FRAMEWORK>              The target framework to run tests for. The target framework must also be specified in the project file.
  --runtime <RUNTIME_IDENTIFIER>           The target runtime to test for.
  -o, --output <OUTPUT_DIR>                The output directory to place built artifacts in.
  -d, --diag <LOG_FILE>                    Enable verbose logging to the specified file.
  --no-build                               Do not build the project before testing. Implies --no-restore.
  -r, --results-directory <RESULTS_DIR>    The directory where the test results will be placed.
                                           The specified directory will be created if it does not exist.
  --collect <DATA_COLLECTOR_NAME>          The friendly name of the data collector to use for the test run.
                                           More info here: https://aka.ms/vstest-collect
  --blame                                  Run the tests in blame mode. This option is helpful in isolating a problematic test causing the test host to crash.
                                           Outputs a 'Sequence.xml' file in the current directory that captures the order of execution of test before the crash.
  --no-restore                             Do not restore the project before building.
  -v, --verbosity <LEVEL>                  Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic].

@skovsende

This comment has been minimized.

Copy link

commented May 28, 2019

And dotnet pack has the same problem I believe :)

@stasostrovskyi

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

I would like to take this issue. Just missing parameter(s) seems to be a small issue. But it will take some time for me, I haven't seen Cake codebase for a really long time :)

@patriksvensson

This comment has been minimized.

Copy link
Member

commented May 28, 2019

@stasostrovskyi Perfect! If you have any questions then ping me and I'll try to help out the best I can!

@patriksvensson patriksvensson added Taken and removed Up-for-grabs labels May 28, 2019

@devlead devlead added Improvement and removed Help wanted Taken labels Jun 5, 2019

@devlead devlead added this to the v0.34.0 milestone Jun 5, 2019

@devlead devlead closed this in #2562 Jun 5, 2019

devlead added a commit that referenced this issue Jun 5, 2019

Merge branch 'stasostrovskyi-stasostrovskyi-feature/GH-2556' into dev…
…elop

* stasostrovskyi-stasostrovskyi-feature/GH-2556:
  Added Runtime to DotNetCoreTestSettings and test for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.