Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Core 3 to Cake.Tool update to .NET Core 3 SDK #2603

Closed
devlead opened this issue Aug 17, 2019 · 10 comments · Fixed by #2604

Comments

@devlead
Copy link
Member

commented Aug 17, 2019

  • Add netcoreapp3.0 moniker to Cake.Tool
  • Execute unit tests under netcoreapp3.0
  • Update SDK to .NET Core 3
@devlead devlead added the Improvement label Aug 17, 2019
@devlead devlead self-assigned this Aug 17, 2019
devlead added a commit to devlead/cake that referenced this issue Aug 17, 2019
* Updated SDK to .NET Core 3 (3.0.100-preview8-013656)
* Added netcoreapp3.0 moniker to Cake.Tool
* Added netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidated Cake.Tool.csproj into Cake.csproj (sorts VS2019 issues)
* fixes cake-build#2603
devlead added a commit to devlead/cake that referenced this issue Sep 4, 2019
* Updated SDK to .NET Core 3 (3.0.100-preview9-014004)
* Added netcoreapp3.0 moniker to Cake.Tool
* Added netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidated Cake.Tool.csproj into Cake.csproj (sorts VS2019 issues)
* fixes cake-build#2603
devlead added a commit to devlead/cake that referenced this issue Sep 4, 2019
* Updated SDK to .NET Core 3 (3.0.100-preview9-014004)
* Added netcoreapp3.0 moniker to Cake.Tool
* Added netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidated Cake.Tool.csproj into Cake.csproj (sorts VS2019 issues)
* fixes cake-build#2603
@peppy peppy referenced this issue Sep 13, 2019
1 of 1 task complete
devlead added a commit to devlead/cake that referenced this issue Sep 17, 2019
* Updated SDK to .NET Core 3 (3.0.100-preview9-014004)
* Added netcoreapp3.0 moniker to Cake.Tool
* Added netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidated Cake.Tool.csproj into Cake.csproj (sorts VS2019 issues)
* fixes cake-build#2603
devlead added a commit to devlead/cake that referenced this issue Sep 18, 2019
* Update SDK to .NET Core 3 (3.0.100-rc1-014190)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1-beta3-final (needs to be non-prerelease before merge)
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0
* Temp fix for rollforward test
* fixes cake-build#2603
devlead added a commit to devlead/cake that referenced this issue Sep 18, 2019
* Update SDK to .NET Core 3 (3.0.100-rc1-014190)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1-beta3-final (needs to be non-prerelease before merge)
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0
* Temp fix for rollforward test
* fixes cake-build#2603
@myloveCc

This comment has been minimized.

Copy link

commented Sep 24, 2019

Please update nuget package to .NET Core 3.0, Thanks!

devlead added a commit to devlead/cake that referenced this issue Sep 24, 2019
* Update SDK to .NET Core 3 (3.0.100)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0
* Temp fix for rollforward test
* fixes cake-build#2603
@devlead

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

Please update nuget package to .NET Core 3.0, Thanks!
We've got an open PR ( #2604 ) which is under going final review.

Meanwhile you can use the .NET Core 2.1 tool in a pure 3.0 SDK environment by setting the environment key DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX to 2, 2 indicates you opting in to allow rolling forward to next major release.

devlead added a commit to devlead/cake that referenced this issue Sep 24, 2019
* Update SDK to .NET Core 3 (3.0.100)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0
* Temp fix for rollforward test
* fixes cake-build#2603
devlead added a commit to devlead/cake that referenced this issue Sep 24, 2019
* Update SDK to .NET Core 3 (3.0.100)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0
* Temp fix for rollforward test
* fixes cake-build#2603
@RehanSaeed

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

I'm having trouble running dotnet cake CLI commands on Azure Pipelines. I'm manually installing. NET Core 3.0 but getting this error when I run 'dotnet cake':

It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.1.0' was not found.

  • The following frameworks were found:
    3.0.0 at [/opt/hostedtoolcache/dotnet/shared/Microsoft.NETCore.App]
    You can resolve the problem by installing the specified framework and/or SDK.

What I don't understand is that AppVeyor still works. Do I need to wait for this upgrade to be released or is something else going on? Links to my repo and Build output.

@devlead

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2019

@RehanSaeed have you set environment variable DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX to 2 to allow major roll forward?
(it works on AppVeyor because they've got 2.0, 2.1 and 2.2 installed already on agent)

@RehanSaeed

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

No. Azure Pipelines already has older versions of. NET Core installed on their hosted build machines, so in theory I shouldn't need to right? I guess it wouldn't hurt to try.

@devlead

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2019

Could be that the UseDotNet@2task installs in a non standard folder and sets path to that, because I've needed to install all SDKs I want to support something like this (if 2.0 and 2.1 needed i.e.)

steps:
- task: UseDotNet@2
  displayName: 'Use .Net Core sdk 2.1.202'
  inputs:
    version: 2.1.202

- task: UseDotNet@2
  displayName: 'Use .Net Core sdk 2.1.701'
  inputs:
    version: 2.1.701

- task: UseDotNet@2
  displayName: 'Use .Net Core sdk 3.0.100'
  inputs:
    version: 3.0.100

Setting DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX to 2 would allow you to have a pure 3.0 env though until Cake.Tool is released with netcoreapp3.0 moniker.

@RehanSaeed

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

According to the docs:

$(Agent.ToolsDirectory): This makes the version to be cached on the agent since this directory is not cleanup up across pipelines. All pipelines running on the agent, would have access to the versions installed previously using the agent.

It says previous versions should still work.

devlead added a commit to devlead/cake that referenced this issue Sep 25, 2019
* Update SDK to .NET Core 3 (3.0.100)
* Add netcoreapp3.0 moniker to Cake.Tool
* Add netcoreapp3.0 moniker to Unit tests
* Execute unit tests under netcoreapp3.0
* Consolidate Cake.Tool.csproj into Cake.csproj (sorts VS2019 rebuild issues)
* Refactor Runtime Framework detection
* Microsoft.CodeAnalysis.CSharp.Scripting 3.3.1
* Remove mono workaround
* Add .NET Core rollForward policy
* Build script cleanup
* Update NuGet command line to 5.2.0 (5.3.0 not blessed yet)
* Update NuGet Client libs to 5.3.0
* Temp fix for rollforward test
* fixes cake-build#2603
@RehanSaeed

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Adding DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX: 2 worked by the way. Long live Cake Build!

patriksvensson added a commit that referenced this issue Sep 27, 2019
GH2603: Added .NET Core 3 moniker to Cake.Tool
@RehanSaeed

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

@patriksvensson What is the ETA for a release of Cake.Tool? Does it get release separetely from the rest of cake?

@gep13

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@RehanSaeed it gets released at the same time as Cake, not separately.

It is on the Azure Artifacts feed though:

https://dev.azure.com/cake-build/Cake/_packaging?_a=package&feed=cake%40Local&package=Cake.Tool&protocolType=NuGet&version=0.35.0-alpha0031

@devlead devlead added this to the v0.35.0 milestone Sep 28, 2019
@devlead devlead added Feature and removed Improvement labels Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.