Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateAssemblyInfo alias creates invalid file when using .vb #2637

Closed
gep13 opened this issue Oct 15, 2019 · 0 comments · Fixed by #2639
Closed

CreateAssemblyInfo alias creates invalid file when using .vb #2637

gep13 opened this issue Oct 15, 2019 · 0 comments · Fixed by #2639
Assignees
Labels
Bug
Milestone

Comments

@gep13
Copy link
Member

@gep13 gep13 commented Oct 15, 2019

When running the following cake script:

Task("Default")
  .Does(() =>
{
  var file = "./SolutionInfo.vb";
var version = "0.0.1";
var buildNo = "123";
var semVersion = string.Concat(version + "-" + buildNo);
CreateAssemblyInfo(file, new AssemblyInfoSettings {
    Product = "SampleProject",
    Version = version,
    FileVersion = version,
    InformationalVersion = semVersion,
    Copyright = string.Format("Copyright (c) Contoso 2014 - {0}", DateTime.Now.Year),
    ComVisible = true
});
});

RunTarget("Default")

The following file is generated:

'------------------------------------------------------------------------------
' <auto-generated>
'     This code was generated by Cake.
' </auto-generated>
'------------------------------------------------------------------------------
Imports System.Reflection
Imports System.Runtime.InteropServices

<Assembly: AssemblyProduct("SampleProject")>
<Assembly: AssemblyVersion("0.0.1")>
<Assembly: AssemblyFileVersion("0.0.1")>
<Assembly: AssemblyInformationalVersion("0.0.1-123")>
<Assembly: AssemblyCopyright("Copyright (c) Contoso 2014 - 2019")>
<Assembly: ComVisible(true)>

This is invalid, as this should be True not true for the ComVisible attribute.

@gep13 gep13 added the Bug label Oct 15, 2019
@gep13 gep13 added this to the v0.36.0 milestone Oct 15, 2019
@gep13 gep13 self-assigned this Oct 15, 2019
gep13 added a commit to gep13/cake that referenced this issue Oct 15, 2019
There is a difference between how C# and VB interpret a boolean value.
C# uses true/false, where as VB uses True/False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.