Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `TFBuild.Environment.Repository.Branch` to `TFBuild.Environment.Repository.BranchName` #2657

Closed
pascalberger opened this issue Nov 5, 2019 · 0 comments · Fixed by #2659
Labels
Milestone

Comments

@pascalberger
Copy link
Member

@pascalberger pascalberger commented Nov 5, 2019

What You Are Seeing?

The TFBuild.Environment.Repository.Branch property actually returns the name of the source branch.

What is Expected?

To make this more clear it should be called SourceBranchName instead of Branch. This would also match the naming of the other properties. To be backwards compatible we can make TFBuild.Environment.Repository.Branch obsolete and add a new property beside it.

What version of Cake are you using?

0.35.0

Are you running on a 32 or 64 bit system?

N/A

What environment are you running on? Windows? Linux? Mac?

N/A

Are you running on a CI Server? If so, which one?

Azure Pipelines

pascalberger added a commit to pascalberger/cake that referenced this issue Nov 5, 2019
pascalberger added a commit to pascalberger/cake that referenced this issue Nov 5, 2019
pascalberger added a commit to pascalberger/cake that referenced this issue Nov 20, 2019
pascalberger added a commit to pascalberger/cake that referenced this issue Nov 20, 2019
mholo65 added a commit that referenced this issue Nov 20, 2019
(GH-2657) Rename TFBuildRepositoryInfo.Branch to TFBuildRepositoryInfo.SourceBranchName
@mholo65 mholo65 added this to the v0.36.0 milestone Nov 20, 2019
@mholo65 mholo65 added the Improvement label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.