Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cake Alias support for GitReleaseManager #2696

Closed
gep13 opened this issue Jan 17, 2020 · 4 comments · Fixed by #2699
Closed

Upgrade Cake Alias support for GitReleaseManager #2696

gep13 opened this issue Jan 17, 2020 · 4 comments · Fixed by #2699
Assignees
Labels
Milestone

Comments

@gep13
Copy link
Member

@gep13 gep13 commented Jan 17, 2020

With the release of version 0.10.x of GitReleaseManager, some new commands were created:

  • discard
  • open

And it would be good to have support for these commands via Cake Aliases.

In addition, a number of new base options were added which should also be supported via the base Settings class:

  • Debug
  • NoLogo
  • Verbose

And finally, support for Username and Password authentication has been deprecated in this release of GitReleaseManager, and the Cake Aliases should also be updated to reflect this.

@gep13 gep13 added the Improvement label Jan 17, 2020
@gep13 gep13 added this to the v0.37.0 milestone Jan 17, 2020
@gep13 gep13 self-assigned this Jan 17, 2020
@gep13

This comment has been minimized.

Copy link
Member Author

@gep13 gep13 commented Jan 17, 2020

@AdmiringWorm did I miss anything in the above? Thanks!

@AdmiringWorm

This comment has been minimized.

Copy link

@AdmiringWorm AdmiringWorm commented Jan 17, 2020

@gep13 nope, you got them all

@gep13

This comment has been minimized.

Copy link
Member Author

@gep13 gep13 commented Jan 17, 2020

@AdmiringWorm perfect! Thanks for the sanity check! 😄

gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
Not entirely sure what this wasn't done initially, but I think it makes
sense to apply this refactoring now.  Makes it easier to add the three
new common options.
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
All of these will default to false, unless otherwise specified.
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
GitReleaseManager is deprecating support for using username/password
when connecting to GitHub, and as such, the Cake Aliases that provide
this functionality should also be marked as Obsolete.
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
Add parsing of common arguments to each alias for GitReleaseManager, as
well as tests for ensuring that they are being output when set.
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
These were created by copying from the create and close methods.
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
gep13 added a commit to gep13/cake that referenced this issue Jan 17, 2020
gep13 added a commit to gep13/cake that referenced this issue Jan 18, 2020
Not sure how/why this wasn't implemented already across all the
methods, but glad that it was caught here.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
Not entirely sure what this wasn't done initially, but I think it makes
sense to apply this refactoring now.  Makes it easier to add the three
new common options.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
All of these will default to false, unless otherwise specified.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
GitReleaseManager is deprecating support for using username/password
when connecting to GitHub, and as such, the Cake Aliases that provide
this functionality should also be marked as Obsolete.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
Add parsing of common arguments to each alias for GitReleaseManager, as
well as tests for ensuring that they are being output when set.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
These were created by copying from the create and close methods.
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
devlead added a commit to gep13/cake that referenced this issue Jan 22, 2020
Not sure how/why this wasn't implemented already across all the
methods, but glad that it was caught here.
devlead added a commit that referenced this issue Jan 22, 2020
@cake-build-bot

This comment has been minimized.

Copy link

@cake-build-bot cake-build-bot commented Feb 1, 2020

🎉 This issue has been resolved in version v0.37.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.