New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to signing service v2 #1936

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
5 participants
@onovotny
Contributor

onovotny commented Nov 28, 2017

Note: you'll find the updated username and password in your lastpass. both should be treated as secure variables in your build system.

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Nov 28, 2017

@onovotny,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Nov 28, 2017

@onovotny,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Show outdated Hide outdated build.cake Outdated
@devlead

LGTM 👍 Works great locally, I'll just do some tests on CI and merge if those pass.

.AppendQuoted(MakeAbsolute(client.Path).FullPath)
.Append("zip")
.AppendQuoted(signClientPath.FullPath)
.Append("sign")

This comment has been minimized.

@onovotny

onovotny Nov 29, 2017

Contributor

Yes, thanks missed this one, thanks for catching it!

@onovotny

onovotny Nov 29, 2017

Contributor

Yes, thanks missed this one, thanks for catching it!

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Nov 29, 2017

Member

@onovotny should this repo also be updated https://github.com/cake-build/bakery?

Member

mholo65 commented Nov 29, 2017

@onovotny should this repo also be updated https://github.com/cake-build/bakery?

@onovotny

This comment has been minimized.

Show comment
Hide comment
@onovotny

onovotny Nov 29, 2017

Contributor

@mholo65 Yes, didn't see that, but should be the same set of changes. Anywhere you are signing with the existing service/config should be moved over.

BTW, the service does support VSIX's if you have any addin's/templates.

Contributor

onovotny commented Nov 29, 2017

@mholo65 Yes, didn't see that, but should be the same set of changes. Anywhere you are signing with the existing service/config should be moved over.

BTW, the service does support VSIX's if you have any addin's/templates.

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Nov 29, 2017

Member

@onovotny thanks! I’ll update that one then.

Do we sign VSIX packages? @gep13 @agc93?

Member

mholo65 commented Nov 29, 2017

@onovotny thanks! I’ll update that one then.

Do we sign VSIX packages? @gep13 @agc93?

@gep13

This comment has been minimized.

Show comment
Hide comment
@gep13

gep13 Nov 29, 2017

Member

@mholo65 no, we aren't currently signing VSIX packages. We probably should. Both the Visual Studio and Visual Studio Code packages.

Member

gep13 commented Nov 29, 2017

@mholo65 no, we aren't currently signing VSIX packages. We probably should. Both the Visual Studio and Visual Studio Code packages.

@onovotny

This comment has been minimized.

Show comment
Hide comment
@onovotny

onovotny Nov 29, 2017

Contributor

Sign all the things! :)

Contributor

onovotny commented Nov 29, 2017

Sign all the things! :)

@devlead devlead merged commit b73bdf2 into cake-build:develop Nov 29, 2017

5 checks passed

Cake Develop (Cake) TeamCity build finished
Details
CodeFactor No issues found.
Details
ci/bitrise/7a9d707b00881436/pr Passed - OSX Cake
Details
ci/bitrise/b811c91a26b1ea80/pr Passed - Ubuntu Cake
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@devlead

This comment has been minimized.

Show comment
Hide comment
@devlead

devlead Nov 29, 2017

Member

@onovotny your changes have been merged, thanks for your contribution 👍

Member

devlead commented Nov 29, 2017

@onovotny your changes have been merged, thanks for your contribution 👍

@onovotny onovotny deleted the onovotny:signservice-v2 branch Nov 29, 2017

@gep13

This comment has been minimized.

Show comment
Hide comment
@gep13

gep13 Dec 11, 2017

Member

@onovotny @devlead was there a linked issue for this PR?

Member

gep13 commented Dec 11, 2017

@onovotny @devlead was there a linked issue for this PR?

@gep13 gep13 added this to the v0.24.0 milestone Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment