GH2333: Rewrite Cake CLI (RFC-0001)

[patriksvensson]

RFC: 0001

Notes

I'm putting the code temporarily in it's own project (Cake.Client) to avoid merge conflicts. Before merging, this project should replace the Cake project.

Progress

Aliases

• IEnumerable<T> Arguments<T>(string name)

Features

• Compilation
• Debugging
• Bootstrapping
• Dry run
• Tree
• Descriptions
• Version
• Info

Other

• Module loading
• Multiple arguments with the same name

[patriksvensson]

@cake-build/cake-team Anyone want to take a look at this?

[patriksvensson]

@cake-build/cake-team Fixed stuff, squashed commits and rebased against develop. Could you guys take a look?

[devlead]

@cake-build/cake-team I've rebased this one against latest develop and fixed a few stylecop issues and merge conflicts with package references.
It should be ready for review now.

[ecampidoglio]

The original RFC proposed the introduction of verbs to trigger certain behaviors. For example:

cake bootstrap

instead of

cake --bootstrap

Has this idea been dropped? It doesn't seem to be part of this PR.

[gep13]

@ecampidoglio my understanding was that with this rewrite, there would now be an implicit bootstrapping performed, without the need to trigger anything. I haven't had a chance to take this for a spin yet though.

[ecampidoglio]

@gep13 Nice. That would mean we can remove the bootstrap option from the cake-action at some point.

Regarding the verbs, the RFC described the introduction of a build command, similar to dotnet build:

It would make it easier to use Cake if we introduced proper commands and subcommands like most people are used to from applications such as git and dotnet. Of course we would need to be backwards compatible with how Cake works today (without commands and sub commands) but this functionality could be phased out before a 1.0 release of Cake. The build command should however be the default command.

However, I couldn't find any traces of this in the PR. Has the idea been scrapped or postponed?

[gep13]

@ecampidoglio hmm, not sure on that. That would be a question for @patriksvensson

[patriksvensson]

@ecampidoglio You're absolutely right. I haven't added it since we haven't had a proper discussion about what commands we should expose from the root.

I'll write up a proposal later today!

[devlead]

@cake-build/cake-team I've rebased this one against latest develop.
Please review.

[gep13]

Just a few small comments/suggestions.

[gep13]

LGTM!

[gep13]

@patriksvensson your changes have been merged, thanks for your contribution 👍