New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH2333: Rewrite Cake CLI (RFC-0001) #2334
Conversation
@cake-build/cake-team Anyone want to take a look at this? |
@cake-build/cake-team Fixed stuff, squashed commits and rebased against develop. Could you guys take a look? |
@cake-build/cake-team I've rebased this one against latest develop and fixed a few stylecop issues and merge conflicts with package references. |
The original RFC proposed the introduction of verbs to trigger certain behaviors. For example: cake bootstrap instead of cake --bootstrap Has this idea been dropped? It doesn't seem to be part of this PR. |
@ecampidoglio my understanding was that with this rewrite, there would now be an implicit bootstrapping performed, without the need to trigger anything. I haven't had a chance to take this for a spin yet though. |
@gep13 Nice. That would mean we can remove the Regarding the verbs, the RFC described the introduction of a
However, I couldn't find any traces of this in the PR. Has the idea been scrapped or postponed? |
@ecampidoglio hmm, not sure on that. That would be a question for @patriksvensson |
@ecampidoglio You're absolutely right. I haven't added it since we haven't had a proper discussion about what commands we should expose from the root. I'll write up a proposal later today! |
@cake-build/cake-team I've rebased this one against latest develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@patriksvensson your changes have been merged, thanks for your contribution 👍 |
RFC: 0001
Notes
I'm putting the code temporarily in it's own project (Cake.Client) to avoid merge conflicts. Before merging, this project should replace the
Cake
project.Progress
Aliases
IEnumerable<T> Arguments<T>(string name)
Features
Other