Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2333: Rewrite Cake CLI (RFC-0001) #2334

Open
wants to merge 1 commit into
base: develop
from

Conversation

@patriksvensson
Copy link
Member

commented Oct 18, 2018

RFC: 0001

Notes

I'm putting the code temporarily in it's own project (Cake.Client) to avoid merge conflicts. Before merging, this project should replace the Cake project.

Progress

Aliases

  • IEnumerable<T> Arguments<T>(string name)

Features

  • Compilation
  • Debugging
  • Bootstrapping
  • Dry run
  • Tree
  • Descriptions
  • Version
  • Info

Other

  • Module loading
  • Multiple arguments with the same name

Questions

  • Should we move ICakeDebugger (and impl) to Cake.Core?

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch from d2bf8b8 to badd928 Oct 18, 2018

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch 7 times, most recently from b5d4751 to 3d9965a Nov 2, 2018

Show resolved Hide resolved src/Cake/Cake.csproj Outdated
Show resolved Hide resolved src/Cake/Features/CakeFeature.cs Outdated
Show resolved Hide resolved src/Cake/Infrastructure/Composition/ModuleLoader.cs
Show resolved Hide resolved src/Cake/Infrastructure/ContainerBootstrapper.cs Outdated
Show resolved Hide resolved src/Cake/Infrastructure/Diagnostics/CakeDebugger.cs Outdated
Show resolved Hide resolved src/Cake.Core/CakeArguments.cs
Show resolved Hide resolved src/Cake.Core/Graph/CakeGraph.cs Outdated
Show resolved Hide resolved src/Cake.Core/ICakeArguments.cs Outdated
Show resolved Hide resolved src/Cake.Core/Properties/AssemblyInfo.cs Outdated
Show resolved Hide resolved src/Cake.Core/Properties/AssemblyInfo.cs

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch 2 times, most recently from 3b5601b to 7cbf96b Feb 7, 2019

@patriksvensson

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

@cake-build/cake-team Anyone want to take a look at this?

Show resolved Hide resolved build.cake Outdated
Show resolved Hide resolved build.cake Outdated
Show resolved Hide resolved src/Cake.Core/Scripting/ScriptRunner.cs
Show resolved Hide resolved src/Cake/Features/Bootstrapping/BootstrapFeature.cs

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch 2 times, most recently from 6faf9f5 to 2881cbe Feb 27, 2019

@patriksvensson

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

@cake-build/cake-team Fixed stuff, squashed commits and rebased against develop. Could you guys take a look?

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch 4 times, most recently from 189f151 to 8b15dd3 Mar 19, 2019

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch from 8b15dd3 to 067ea2c Apr 30, 2019

@patriksvensson patriksvensson force-pushed the patriksvensson:feature/RFC-0001 branch from 067ea2c to 6221151 May 16, 2019

@patriksvensson patriksvensson added the RFC label Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.